more github editor accessibility fixes#11431
Merged
Merged
Conversation
srietkerk
reviewed
Jun 26, 2026
| choices, | ||
| selectedId, | ||
| onChoiceSelected | ||
| onChoiceSelected, |
Contributor
There was a problem hiding this comment.
Should this comma be here?
Member
There was a problem hiding this comment.
it's nice to leave trailing commas in lists / etc in ts when they're each on separate lines, because it makes future changes diff better (you don't get a line noted as changed that is just adding , to an existing line) / ts just treats as normal
jwunderl
approved these changes
Jun 26, 2026
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contains a fix for microsoft/pxt-microbit#6851
adds a visual label to the commit message field and replaces it with a react-common input to match our other inputs
contains a fix for microsoft/pxt-microbit#6845
contains a fix for microsoft/pxt-microbit#6846
switched to react-common radio button group and made sure all labels are properly associated
contains a fix for microsoft/pxt-microbit#6861
set the aria-label on the github button in addition to the title