Skip to content

Run link verification before steps that build project #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alzimmermsft wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Run link verification before steps that build project #2233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions eng/pipelines/templates/jobs/analyze.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ jobs:
packageType: sdk
version: 9.0.x

- template: /eng/common/pipelines/templates/steps/verify-links.yml
Copy link
Copy Markdown
Contributor

@jongio jongio Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this step doesn't have continueOnError: true and the downstream analysis steps use the default succeeded() condition, a link verification failure would now block source analysis, AOT analysis, and spell check from running.

If the intent is faster link feedback without gating the build, consider adding condition: succeededOrFailed() to those downstream steps - same pattern used by the README validation step at the bottom of this file.

Or if you want links to be a hard gate, this is fine as-is - just wanted to flag the change in behavior.

parameters:
Condition: succeededOrFailed()
Directory: ""
CheckLinkGuidance: $true
${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
Urls: (eng/common/scripts/get-markdown-files-from-changed-files.ps1)

- task: Powershell@2
displayName: "Run source analysis"
inputs:
Expand All @@ -34,14 +42,6 @@ jobs:

- template: /eng/common/pipelines/templates/steps/check-spelling.yml

- template: /eng/common/pipelines/templates/steps/verify-links.yml
parameters:
Condition: succeededOrFailed()
Directory: ""
CheckLinkGuidance: $true
${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
Urls: (eng/common/scripts/get-markdown-files-from-changed-files.ps1)

- pwsh: |
# Verify that the package README.md files do not contain invalid headers or comment annotations
$hasFailures = & "$(Build.SourcesDirectory)/eng/scripts/Process-PackageReadMe.ps1" -Command "validate-all"
Expand Down