fix: clean up fast-element dependency hierarchy and update to 2.10.4#36184
Merged
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
AtishayMsft
approved these changes
May 11, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
radium-v
force-pushed
the
fix-fast-element-deps
branch
from
0e067a5 to
531b809
Compare
radium-v
force-pushed
the
fix-fast-element-deps
branch
from
531b809 to
f8b2e80
Compare
tudorpopams
approved these changes
May 12, 2026
radium-v
force-pushed
the
fix-fast-element-deps
branch
from
f8b2e80 to
948564c
Compare
marchbox
approved these changes
May 12, 2026
janechu
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
@microsoft/fast-elementdependency was pinned to version2.0.0across multiple packages, and the dependency hierarchy had several issues:packages/web-components/package.jsonlisted@microsoft/fast-elementand@microsoft/focusgroup-polyfillasdevDependenciesdespite already declaring them aspeerDependencies, duplicating the hoisted entries unnecessarily.packages/charts/chart-web-components/package.jsonhad a redundantdevDependenciesentry for@microsoft/fast-elementpinned to2.0.0, and itspeerDependenciesrange included the pre-release syntax^2.0.0-beta.26 || ^2.0.0.apps/vr-tests-web-components/package.jsonpinned@microsoft/fast-elementto exactly2.0.0.package.jsondid not hoist@microsoft/fast-element, so the resolved version inyarn.lockwas stuck at2.0.0.New Behavior
devDependenciesentries for@microsoft/fast-elementand@microsoft/focusgroup-polyfillfrompackages/web-components/package.jsonsince they are already declared aspeerDependenciesand satisfied by the root.devDependenciesentry for@microsoft/fast-elementfrompackages/charts/chart-web-components/package.json.peerDependenciesrange inchart-web-componentsto^2.0.0(dropping the unnecessary beta range).apps/vr-tests-web-componentsto use^2.0.0instead of the exact pin.@microsoft/fast-elementat version2.10.4to the rootdevDependenciesso it is hoisted and all workspace packages resolve to the same up-to-date version.yarn.locknow resolves@microsoft/fast-elementto2.10.4.