chore(web-components): use component tag name constants in playwright tests#36183
Open
radium-v wants to merge 4 commits into
Open
chore(web-components): use component tag name constants in playwright tests#36183radium-v wants to merge 4 commits into
radium-v wants to merge 4 commits into
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
marchbox
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Playwright spec files hardcoded component tag names as string literals (e.g.,
'fluent-accordion','fluent-accordion-item'). Additionally, thefastPagefixture automatically calledsetTemplate()during setup, which meant tests could silently depend on that implicit initialization without expressing their own template requirements.New Behavior
tagName(and related tag name constants) from each component's.options.jsmodule and use those constants fortest.use(),document.createElement(),element.locator(), and HTML template strings.fastPage.setTemplate()call has been removed from the test fixture, so every test must explicitly callsetTemplate()with the template it needs, making each test's DOM setup self-describing.