Skip to content

Updated bar role from image to button based on the props to fix voice control issue in accessibility mode #36096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v-baambati wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Updated bar role from image to button based on the props to fix voice control issue in accessibility mode #36096

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
374a473
Updated bar role from image to button based on the props to fix voice…
v-baambati May 5, 2026
e9e7c8f
Added change file
v-baambati May 5, 2026
b94c045
Updated bar role from image to button based on the props to fix voice…
v-baambati May 6, 2026
9639b2e
Updated bar role from image to button based on the props to fix voice…
v-baambati May 6, 2026
64d2e56
Merge branch 'master' of https://github.com/microsoft/fluentui into M…
v-baambati May 6, 2026
453a8c2
Updated snashots
v-baambati May 6, 2026
d757798
Updated snashots
v-baambati May 6, 2026
3d21570
Updated failed test cases
v-baambati May 6, 2026
f44e621
Merge branch 'master' of https://github.com/microsoft/fluentui into M…
v-baambati May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charts-50b75273-008f-4416-bf72-db392da9bdc5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Accessibility bug fix",
"packageName": "@fluentui/react-charts",
"email": "132879294+v-baambati@users.noreply.github.com",
"dependentChangeType": "patch"
}
9 changes: 7 additions & 2 deletions ...ages/charts/react-charts/library/src/components/HorizontalBarChart/HorizontalBarChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,13 +320,18 @@ export const HorizontalBarChart: React.FunctionComponent<HorizontalBarChartProps
_showToolTipOnSegment && point.legend !== '' ? event => _hoverOn(event, xValue, point) : undefined
Copy link
Copy Markdown

@github-actions github-actions Bot May 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/CalendarCompat 4 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png 496 Changed
vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png 1230 Changed
vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png 1109 Changed
vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png 497 Changed
vr-tests-react-components/Charts-DonutChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png 5570 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.chromium.png 744 Changed
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 136 Changed
vr-tests-react-components/ProgressBar converged 3 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png 33 Changed
vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png 157 Changed
vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png 174 Changed
vr-tests-react-components/Skeleton converged 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Skeleton converged.Opaque Skeleton with square - Dark Mode.default.chromium.png 4 Changed

There were 1 duplicate changes discarded. Check the build logs for more information.

}
onFocus={_showToolTipOnSegment && point.legend !== '' ? event => _hoverOn(event, xValue, point) : undefined}
role="img"
role={point.onClick || (!props.hideTooltip && point.legend !== '') ? 'button' : 'img'}
Copy link
Copy Markdown
Contributor

@krkshitij krkshitij May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't setting the role as button sufficient for interactive elements? Why update tabIndex?

Copy link
Copy Markdown
Contributor Author

@v-baambati v-baambati May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @krkshitij these changes are sufficient but there is one more issue even non interactive element is focusable with customer for that we need to have tab index related changes.

aria-label={_getAriaLabel(point)}
onBlur={_hoverOff}
onMouseLeave={_hoverOff}
className={classes.barWrapper}
opacity={isLegendSelected ? 1 : 0.1}
tabIndex={_legendHighlighted(point.legend!) || _noLegendHighlighted() ? 0 : undefined}
tabIndex={
(_legendHighlighted(point.legend!) || _noLegendHighlighted()) &&
(point.onClick || (!props.hideTooltip && point.legend !== ''))
? 0
: undefined
}
/>
);
});
Expand Down
12 changes: 6 additions & 6 deletions packages/charts/react-charts/library/src/components/VerticalBarChart/VerticalBarChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,12 +674,12 @@ export const VerticalBarChart: React.FunctionComponent<VerticalBarChartProps> =
onClick={point.onClick}
onMouseOver={event => _onBarHover(point, colorScale(point.y), event)}
aria-label={_getAriaLabel(point)}
role="img"
role={point.onClick || !props.hideTooltip ? 'button' : 'img'}
onMouseLeave={_onBarLeave}
onFocus={event => _onBarFocus(event, point, index, colorScale(point.y))}
onBlur={_onBarLeave}
fill={point.color && !useSingleColor ? point.color : colorScale(point.y)}
tabIndex={!props.hideTooltip && shouldHighlight ? 0 : undefined}
tabIndex={(!props.hideTooltip || point.onClick) && shouldHighlight ? 0 : undefined}
opacity={shouldHighlight ? 1 : 0.1}
rx={props.roundCorners ? 3 : 0}
/>
Expand Down Expand Up @@ -732,7 +732,7 @@ export const VerticalBarChart: React.FunctionComponent<VerticalBarChartProps> =
width={_barWidth}
height={adjustedBarHeight}
aria-label={_getAriaLabel(point)}
role="img"
role={point.onClick || !props.hideTooltip ? 'button' : 'img'}
ref={(e: SVGRectElement) => {
_refCallback(e, point.legend!);
}}
Expand All @@ -742,7 +742,7 @@ export const VerticalBarChart: React.FunctionComponent<VerticalBarChartProps> =
onBlur={_onBarLeave}
onFocus={event => _onBarFocus(event, point, index, colorScale(point.y))}
fill={point.color ? point.color : colorScale(point.y)}
tabIndex={!props.hideTooltip && shouldHighlight ? 0 : undefined}
tabIndex={(!props.hideTooltip || point.onClick) && shouldHighlight ? 0 : undefined}
rx={props.roundCorners ? 3 : 0}
opacity={shouldHighlight ? 1 : 0.1}
/>
Expand Down Expand Up @@ -796,12 +796,12 @@ export const VerticalBarChart: React.FunctionComponent<VerticalBarChartProps> =
onClick={point.onClick}
onMouseOver={event => _onBarHover(point, colorScale(point.y), event)}
aria-label={_getAriaLabel(point)}
role="img"
role={point.onClick || !props.hideTooltip ? 'button' : 'img'}
onMouseLeave={_onBarLeave}
onFocus={event => _onBarFocus(event, point, index, colorScale(point.y))}
onBlur={_onBarLeave}
fill={point.color && !useSingleColor ? point.color : colorScale(point.y)}
tabIndex={!props.hideTooltip && shouldHighlight ? 0 : undefined}
tabIndex={(!props.hideTooltip || point.onClick) && shouldHighlight ? 0 : undefined}
rx={props.roundCorners ? 3 : 0}
opacity={shouldHighlight ? 1 : 0.1}
/>
Expand Down
Loading