Fix zero-width regex replace#815
Merged
lhecker merged 4 commits intomicrosoft:mainfrom Apr 27, 2026
Merged
Conversation
Member
|
I do not like that you submitted this PR without testing it in practice first. That's not per the OSS decorum. |
lhecker
changed the title
lhecker
force-pushed
the
fix-zero-width-replace-all
branch
from
917ee6a to
422244a
Compare
lhecker
reviewed
Apr 27, 2026
| } | ||
|
|
||
| static mut LIBRARY_FUNCTIONS: LibraryFunctionsState = LibraryFunctionsState::Uninitialized; | ||
| static LIBRARY_FUNCTIONS: OnceLock<Option<LibraryFunctions>> = OnceLock::new(); |
Member
There was a problem hiding this comment.
Now that we have concurrent unit tests that rely on ICU, OnceLock is needed.
DHowett
approved these changes
Apr 27, 2026
DHowett
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a drive-by this also puts all replace-all
changes into a single undo group.
Tested by:
$and "x": Every line gets a trailing "x",the final line gets a lone "x" and a new trailing newline is added.
$and "x" repeatedly: New "x"s are added toeach line incrementally, and it wraps around the buffer.
Closes #775