Skip to content

Fix compiler warnings in calc.cpp and trans.cpp #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dongfengweixiao wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix compiler warnings in calc.cpp and trans.cpp #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CalcManager/CEngine/calc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ std::wstring CCalcEngine::GetMaxDecimalValueString() const
// of CCalcEngine. Otherwise it will get destructed with the CalcEngine
unique_ptr<Rational> CCalcEngine::PersistedMemObject()
{
return move(m_memoryValue);
return std::move(m_memoryValue);
}

void CCalcEngine::PersistedMemObject(Rational const& memObject)
Expand Down
6 changes: 6 additions & 0 deletions src/CalcManager/Ratpack/trans.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ void sinanglerat(_Inout_ PRAT* pa, AngleType angletype, uint32_t radix, int32_t
scalerat(pa, angletype, radix, precision);
switch (angletype)
{
case AngleType::Radians:
break;
case AngleType::Degrees:
if (rat_gt(*pa, rat_180, precision))
{
Expand Down Expand Up @@ -199,6 +201,8 @@ void cosanglerat(_Inout_ PRAT* pa, AngleType angletype, uint32_t radix, int32_t
scalerat(pa, angletype, radix, precision);
switch (angletype)
{
case AngleType::Radians:
break;
case AngleType::Degrees:
if (rat_gt(*pa, rat_180, precision))
{
Expand Down Expand Up @@ -269,6 +273,8 @@ void tananglerat(_Inout_ PRAT* pa, AngleType angletype, uint32_t radix, int32_t
scalerat(pa, angletype, radix, precision);
switch (angletype)
{
case AngleType::Radians:
break;
case AngleType::Degrees:
if (rat_gt(*pa, rat_180, precision))
{
Expand Down