Add msr-tools package from upstream#17149
Conversation
| [components.msr-tools] | ||
|
|
||
| [[components.msr-tools.overlays]] | ||
| description = "Normalize Fedora's Release tag to the optional (?) dist macro form so azldev can auto-bump it" |
There was a problem hiding this comment.
Interesting find that the upstream spec uses %{dist} and not %{?dist}!
A few thoughts:
- We should update
azldev(https://github.com/microsoft/azure-linux-dev-tools) to handle this case so this overlay isn't required. - Explicitly setting
30%{?dist}may clobber whatever baseReleasevalue we get from the upstream spec when we rebase against a later set of commits from upstream.
I'd actually recommend getting the change into azldev -- it's simple enough we can expedite it through.
There was a problem hiding this comment.
The non-conditional %{dist} autobump was specifically rejected in this test: https://github.com/microsoft/azure-linux-dev-tools/blob/979370c7b7e32f06ceed2c0adbc797e8a88ae731/internal/app/azldev/core/sources/release_test.go#L74
is there any particular reason for this?
I have for now raised this draft PR to allow autobump for these: microsoft/azure-linux-dev-tools#179
(one-line regex change and some tests)
Can you confirm if this update to azldev is correct? I'll update this msr-tools package tomls accordingly.
There was a problem hiding this comment.
Good question -- I think that was an oversight. Your draft PR looks good to me. I'm happy to approve and merge it once you take it out of draft and it passes PR checks.
There was a problem hiding this comment.
I've opened the PR and all PR checks have passed. Can you please review it?
|
@MadhurAggarwal -- I've merged your PR to azldev; can you try updating this PR? |
2f7207f to
cd55e9f
Compare
Thanks! |
There was a problem hiding this comment.
Pull request overview
Adds the Fedora-imported msr-tools component/spec to the Azure Linux repo so the rdmsr / wrmsr utilities are available as a packaged dependency (e.g., for LISA validation scenarios).
Changes:
- Added the
msr-toolscomponent to the Fedora-import list (components.toml) and introduced its lockfile. - Added rendered spec artifacts for
msr-tools(spec, sources hash, and the upstream patch used by the spec).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| specs/m/msr-tools/sources | Adds the source tarball hash entry for the rendered component. |
| specs/m/msr-tools/msr-tools.spec | Introduces the rendered RPM spec for building/packaging msr-tools. |
| specs/m/msr-tools/bz1268604-increase-max-procs.patch | Adds the patch referenced by the spec to increase supported CPU index range. |
| locks/msr-tools.lock | Adds the azldev-managed lock pinning the imported upstream commit and input fingerprint. |
| base/comps/components.toml | Registers msr-tools as an unmodified Fedora-imported component (needs ordering fix per stored comment). |
reubeno
left a comment
There was a problem hiding this comment.
Did you confirm that this builds in our build services?
e044c04 to
8915631
Compare
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
rdmsr/wrmsrverify_hyperv_platform_idwhich skips due to this missing packageChange Log
Does this affect the toolchain?
NO
Associated issues
WorkItem: https://dev.azure.com/mariner-org/mariner/_workitems/edit/18998/
Test Methodology
Local RPM Build:
