-
Notifications
You must be signed in to change notification settings - Fork 628
fix(repoclosure): retarget openjdk21 references to openjdk25 #17148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
reubeno
wants to merge
4
commits into
tomls/base/main
Choose a base branch
from
users/reubeno/jdkver
base: tomls/base/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b767170
fix: retarget openjdk21 references to openjdk25 across Java stack
reubeno a0534db
fix(stringtemplate4): pin to f44 commit with openjdk25 support
reubeno 1c213e6
fix(xbean): skip failing jdk25 tests via --force on %mvn_buildx
reubeno b5ae3cb
feat: drop libbluray and libudfread; disable Blu-Ray support in consu…
reubeno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,39 @@ | ||
| [components.dogtag-pki] | ||
| # Release: %{release_number}%{?phase:.}%{?phase}%{?timestamp:.}%{?timestamp}%{?commit_id:.}%{?commit_id}%{?dist} | ||
| release = { calculation = "manual" } | ||
|
|
||
| # AZL ships only java-25-openjdk; there is no java-21-openjdk, so the | ||
| # upstream %else branch (taken when %fedora and %rhel are both unset, as | ||
| # in AZL) references unsatisfiable openjdk21 packages. Retarget each | ||
| # %define line individually so we don't accidentally rewrite historical | ||
| # %changelog entries that mention these monikers (spec-search-replace | ||
| # cannot be scoped to the preamble alone). | ||
| [[components.dogtag-pki.overlays]] | ||
| description = "Retarget java_runtime to java-25-openjdk" | ||
| type = "spec-search-replace" | ||
| regex = '^%define java_runtime java-21-openjdk$' | ||
| replacement = "%define java_runtime java-25-openjdk" | ||
|
|
||
| [[components.dogtag-pki.overlays]] | ||
| description = "Retarget java_devel to java-25-openjdk-devel" | ||
| type = "spec-search-replace" | ||
| regex = '^%define java_devel java-21-openjdk-devel$' | ||
| replacement = "%define java_devel java-25-openjdk-devel" | ||
|
|
||
| [[components.dogtag-pki.overlays]] | ||
| description = "Retarget java_headless to java-25-openjdk-headless" | ||
| type = "spec-search-replace" | ||
| regex = '^%define java_headless java-21-openjdk-headless$' | ||
| replacement = "%define java_headless java-25-openjdk-headless" | ||
|
|
||
| [[components.dogtag-pki.overlays]] | ||
| description = "Retarget java_home to jre-25-openjdk" | ||
| type = "spec-search-replace" | ||
| regex = '^%define java_home %\{_jvmdir\}/jre-21-openjdk$' | ||
| replacement = "%define java_home %{_jvmdir}/jre-25-openjdk" | ||
|
|
||
| [[components.dogtag-pki.overlays]] | ||
| description = "Retarget maven_local to maven-local-openjdk25" | ||
| type = "spec-search-replace" | ||
| regex = '^%define maven_local maven-local-openjdk21$' | ||
| replacement = "%define maven_local maven-local-openjdk25" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| [components.gvfs] | ||
|
|
||
| # AZL does not ship libbluray — Blu-Ray playback support is dropped from gvfs. | ||
|
|
||
| [[components.gvfs.overlays]] | ||
| description = "Drop BuildRequires: pkgconfig(libbluray) (libbluray not available in AZL)" | ||
| type = "spec-remove-tag" | ||
| tag = "BuildRequires" | ||
| value = "pkgconfig(libbluray)" | ||
|
|
||
| [[components.gvfs.overlays]] | ||
| description = "Pass -Dbluray=false to meson unconditionally (libbluray not available in AZL)" | ||
| type = "spec-search-replace" | ||
| section = "%build" | ||
| regex = '-Dman=true \\' | ||
| replacement = "-Dman=true \\\n -Dbluray=false \\" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| [components.plexus-velocity] | ||
|
|
||
| # AZL ships only java-25-openjdk; there is no java-21-openjdk, so the | ||
| # upstream BuildRequires on maven-local-openjdk21 is unsatisfiable. | ||
| # Retarget to the openjdk25 variant. | ||
| [[components.plexus-velocity.overlays]] | ||
| description = "Remove BuildRequires on maven-local-openjdk21 — AZL does not ship java-21-openjdk" | ||
| type = "spec-remove-tag" | ||
| tag = "BuildRequires" | ||
| value = "maven-local-openjdk21" | ||
|
|
||
| [[components.plexus-velocity.overlays]] | ||
| description = "Add BuildRequires on maven-local-openjdk25 in place of maven-local-openjdk21" | ||
| type = "spec-add-tag" | ||
| tag = "BuildRequires" | ||
| value = "maven-local-openjdk25" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| [components.resteasy] | ||
|
|
||
| # AZL ships only java-25-openjdk; there is no java-21-openjdk, so the | ||
| # upstream BuildRequires on maven-local-openjdk21 is unsatisfiable. | ||
| # Retarget to the openjdk25 variant. | ||
| [[components.resteasy.overlays]] | ||
| description = "Remove BuildRequires on maven-local-openjdk21 — AZL does not ship java-21-openjdk" | ||
| type = "spec-remove-tag" | ||
| tag = "BuildRequires" | ||
| value = "maven-local-openjdk21" | ||
|
|
||
| [[components.resteasy.overlays]] | ||
| description = "Add BuildRequires on maven-local-openjdk25 in place of maven-local-openjdk21" | ||
| type = "spec-add-tag" | ||
| tag = "BuildRequires" | ||
| value = "maven-local-openjdk25" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| [components.stringtemplate4] | ||
|
|
||
| # AZL otherwise tracks Fedora 43, but the f43 stringtemplate4 still | ||
| # BuildRequires maven-local-openjdk21, which AZL does not ship (we only | ||
| # ship java-25-openjdk). Pin to a Fedora 44 commit on the f44 branch that | ||
| # moves the package forward to openjdk25 and includes the corresponding | ||
| # build fixes. | ||
| # Fedora commit: https://src.fedoraproject.org/rpms/stringtemplate4/c/0a6adaa584f3670857a931ff971b283213dfcfd7?branch=f44 | ||
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "44" }, upstream-commit = "0a6adaa584f3670857a931ff971b283213dfcfd7" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| [components.xbean] | ||
|
|
||
| # AZL ships only java-25-openjdk; there is no java-21-openjdk, so the | ||
| # upstream BuildRequires on maven-local-openjdk21 is unsatisfiable. | ||
| # Retarget to the openjdk25 variant. | ||
| [[components.xbean.overlays]] | ||
| description = "Remove BuildRequires on maven-local-openjdk21 — AZL does not ship java-21-openjdk" | ||
| type = "spec-remove-tag" | ||
| tag = "BuildRequires" | ||
| value = "maven-local-openjdk21" | ||
|
|
||
| [[components.xbean.overlays]] | ||
| description = "Add BuildRequires on maven-local-openjdk25 in place of maven-local-openjdk21" | ||
| type = "spec-add-tag" | ||
| tag = "BuildRequires" | ||
| value = "maven-local-openjdk25" | ||
|
|
||
| # Backport from Fedora rawhide commit (the test-skip portion of): | ||
| # https://src.fedoraproject.org/rpms/xbean/c/1df289d87c3617482e813a5dac348b01c67d271f?branch=rawhide | ||
| # Upstream tests fail under jdk25; rawhide added `--force` to `%mvn_build` | ||
| # so the build proceeds despite test failures. The openjdk21 -> openjdk25 | ||
| # portion of that same commit is handled by the BuildRequires overlays | ||
| # above. Drop this overlay once the default Fedora 43 snapshot in | ||
| # distro/azurelinux.distro.toml advances past a commit that includes this | ||
| # change. | ||
| [[components.xbean.overlays]] | ||
| description = "Pass --force to %mvn_build to skip tests that fail under jdk25 (backport from Fedora rawhide)" | ||
| type = "spec-search-replace" | ||
| regex = '^%mvn_build -- ' | ||
| replacement = '%mvn_build --force -- ' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # Managed by azldev component update. Do not edit manually. | ||
| version = 1 | ||
| import-commit = 'bdb23f939020f7916ed21c9033ecfd6b83b575d9' | ||
| upstream-commit = 'bdb23f939020f7916ed21c9033ecfd6b83b575d9' | ||
| input-fingerprint = 'sha256:32d618b9d809fb99c1c2fbc331cae4f259d76a8f5191e510eced8b4ff04dd2dd' | ||
| resolution-input-hash = 'sha256:466421704711c4fd3c71f0b2ed715a0e61d49e3e26f3a2637fee755795849c8e' | ||
| upstream-commit = '0a6adaa584f3670857a931ff971b283213dfcfd7' | ||
| input-fingerprint = 'sha256:a25850dc7fb6041bff0e72d9d5666ac7085790a02ae3bfb81a3082580024bfcd' | ||
| resolution-input-hash = 'sha256:3dfbb4dd503c0097e2fcb6dee544a989bace0bbc21d2db478554d18dae1daece' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.