Open
Conversation
- Update Spectre.Console from 0.52.1-preview.0.5 to 0.55.0 - Use AnsiCapabilities.Create for ANSI detection instead of creating a full AnsiConsole instance - Implement IAnsiConsole.WriteAnsi in test helper
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16106Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16106" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Aspire CLI’s Spectre.Console dependency and adapts CLI/test code to the updated ANSI capability detection and console interface surface area.
Changes:
- Bump
Spectre.Consolefrom0.52.1-preview.0.5to0.55.0. - Switch ANSI detection in
CliHostEnvironmenttoAnsiCapabilities.Create(Console.Out). - Update the test
IAnsiConsolewrapper to implementIAnsiConsole.WriteAnsi.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Directory.Packages.props | Updates central package version for Spectre.Console. |
| src/Aspire.Cli/Utils/CliHostEnvironment.cs | Uses new Spectre ANSI capability detection API instead of creating an AnsiConsole instance. |
| tests/Aspire.Cli.Tests/Interaction/ConsoleInteractionServiceTests.cs | Implements newly-required IAnsiConsole.WriteAnsi on a test console wrapper. |
Spectre.Console's GitHubEnricher sets Links=false when GITHUB_ACTIONS is detected, which prevents OSC 8 hyperlink sequences from being emitted. Disable default enrichers in tests to get consistent behavior across local and CI environments.
Replace the AnsiConsole.Create workaround with the new AnsiCapabilities.Create API from Spectre.Console.Ansi, which provides direct ANSI capability detection without creating a full AnsiConsole instance.
Contributor
|
🎬 CLI E2E Test Recordings — 68 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24325248928 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Spectre.Console from 0.52.1-preview.0.5 to 0.55.0.
Changes
Spectre.Consoleversion from0.52.1-preview.0.5to0.55.0AnsiConsoleinstance for ANSI detection with the newAnsiCapabilities.Create(Console.Out)API fromSpectre.Console.Ansi(transitive dependency)IAnsiConsole.WriteAnsiinterface member added in 0.55.0 on the test helper classChecklist