-
Notifications
You must be signed in to change notification settings - Fork 860
Add multiple DNS zones for Foundry private endpoint #16051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eerhardt
wants to merge
1
commit into
microsoft:main
Choose a base branch
from
eerhardt:SupportMultiplePrivateDNS
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:Aspire.Hosting.Azure.IAzurePrivateEndpointTarget.GetPrivateDnsZoneName</Target> | ||
| <Left>lib/net8.0/Aspire.Hosting.Azure.dll</Left> | ||
| <Right>lib/net8.0/Aspire.Hosting.Azure.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0006</DiagnosticId> | ||
| <Target>M:Aspire.Hosting.Azure.IAzurePrivateEndpointTarget.GetPrivateDnsZoneNames</Target> | ||
| <Left>lib/net8.0/Aspire.Hosting.Azure.dll</Left> | ||
| <Right>lib/net8.0/Aspire.Hosting.Azure.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| </Suppressions> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
...ensionsTests.AddPrivateEndpoint_CreatesMultipleDnsZones_ForMultiZoneTarget.verified.bicep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| @description('The location for the resource(s) to be deployed.') | ||
| param location string = resourceGroup().location | ||
|
|
||
| param privatelink_services_ai_azure_com_outputs_name string | ||
|
|
||
| param privatelink_openai_azure_com_outputs_name string | ||
|
|
||
| param privatelink_cognitiveservices_azure_com_outputs_name string | ||
|
|
||
| param myvnet_outputs_pesubnet_id string | ||
|
|
||
| param foundry_outputs_id string | ||
|
|
||
| resource privatelink_services_ai_azure_com 'Microsoft.Network/privateDnsZones@2024-06-01' existing = { | ||
| name: privatelink_services_ai_azure_com_outputs_name | ||
| } | ||
|
|
||
| resource privatelink_openai_azure_com 'Microsoft.Network/privateDnsZones@2024-06-01' existing = { | ||
| name: privatelink_openai_azure_com_outputs_name | ||
| } | ||
|
|
||
| resource privatelink_cognitiveservices_azure_com 'Microsoft.Network/privateDnsZones@2024-06-01' existing = { | ||
| name: privatelink_cognitiveservices_azure_com_outputs_name | ||
| } | ||
|
|
||
| resource pesubnet_foundry_pe 'Microsoft.Network/privateEndpoints@2025-05-01' = { | ||
| name: take('pesubnet_foundry_pe-${uniqueString(resourceGroup().id)}', 64) | ||
| location: location | ||
| properties: { | ||
| privateLinkServiceConnections: [ | ||
| { | ||
| properties: { | ||
| privateLinkServiceId: foundry_outputs_id | ||
| groupIds: [ | ||
| 'account' | ||
| ] | ||
| } | ||
| name: 'pesubnet-foundry-pe-connection' | ||
| } | ||
| ] | ||
| subnet: { | ||
| id: myvnet_outputs_pesubnet_id | ||
| } | ||
| } | ||
| tags: { | ||
| 'aspire-resource-name': 'pesubnet-foundry-pe' | ||
| } | ||
| } | ||
|
|
||
| resource pesubnet_foundry_pe_dnsgroup 'Microsoft.Network/privateEndpoints/privateDnsZoneGroups@2025-05-01' = { | ||
| name: 'default' | ||
| properties: { | ||
| privateDnsZoneConfigs: [ | ||
| { | ||
| name: 'privatelink_services_ai_azure_com' | ||
| properties: { | ||
| privateDnsZoneId: privatelink_services_ai_azure_com.id | ||
| } | ||
| } | ||
| { | ||
| name: 'privatelink_openai_azure_com' | ||
| properties: { | ||
| privateDnsZoneId: privatelink_openai_azure_com.id | ||
| } | ||
| } | ||
| { | ||
| name: 'privatelink_cognitiveservices_azure_com' | ||
| properties: { | ||
| privateDnsZoneId: privatelink_cognitiveservices_azure_com.id | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| parent: pesubnet_foundry_pe | ||
| } | ||
|
|
||
| output id string = pesubnet_foundry_pe.id | ||
|
|
||
| output name string = pesubnet_foundry_pe.name |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checked-in public API baseline sources under
src/*/api/*.csdon't appear to be updated for this interface change. For example,src/Aspire.Hosting.Azure/api/Aspire.Hosting.Azure.csstill declaresIAzurePrivateEndpointTarget.GetPrivateDnsZoneName(), which will cause the public API validation to fail (and may leave other package API baselines out of sync as well). Please regenerate/update theapi/*.csbaselines for the affected packages to reflectGetPrivateDnsZoneNames()and the removal ofGetPrivateDnsZoneName().