Wire up model variant selection instead of hardcoded SqueezeNet path#626
Open
yeelam-gordon wants to merge 1 commit intomainfrom
Open
Wire up model variant selection instead of hardcoded SqueezeNet path#626yeelam-gordon wants to merge 1 commit intomainfrom
yeelam-gordon wants to merge 1 commit intomainfrom
Conversation
UI samples were bypassing the shared FP32/Default model selection logic. Fixes ADO #61791040 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the WindowsML UI samples (WPF, WinUI 3, WinForms) so they no longer hardcode SqueezeNet.onnx and instead allow ModelManager.ResolvePaths() / DetermineModelVariant() to select the appropriate SqueezeNet model variant based on the selected execution provider/device configuration (aligning behavior with the UI selections).
Changes:
- Replaced hardcoded
ModelPath = "SqueezeNet.onnx"with an emptyModelPathso shared model variant selection logic is used. - Added inline comments explaining why
ModelPathmust be empty for variant auto-selection to work. - Applied the same fix consistently across WPF, WinUI, and WinForms sample apps.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Samples/WindowsML/cs-wpf/MainWindow.xaml.cs | Stops hardcoding the SqueezeNet model filename so shared variant selection can choose the correct model. |
| Samples/WindowsML/cs-winui/MainWindow.xaml.cs | Same change for WinUI: clears ModelPath to enable shared model variant selection behavior. |
| Samples/WindowsML/cs-winforms/MainForm.cs | Same change for WinForms: clears ModelPath to avoid bypassing shared model variant selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ADO #61791040
The cs-wpf, cs-winui, and cs-winforms samples had hardcoded model paths ignoring the variant selection UI. This wires up the combo box selection to actually load the chosen model variant.