CmdPal: Improve indexer plain query search#46907
Open
jiripolasek wants to merge 3 commits intomainfrom
Open
Conversation
- Improves simple free-text Windows Search queries with implicit filename broadening while preserving structured AQS input. - Adds resilient fallback behavior for noisy or punctuation-heavy searches by retrying with literal filename matching. - Surfaces Windows Search availability and indexing-status notices in the indexer page and fallback item. - Tightens production logging for datasource, query-execution, and catalog-status failures. - Documents the query-handling heuristics and the paging/notice invariants for future maintainers.
jiripolasek
added
the
Product-Command Palette
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Examples: | ||
|
|
||
| - `foo-bar` | ||
| - `20220409-tontrager.xlsx` |
| - `foo-bar` | ||
| - `20220409-tontrager.xlsx` | ||
|
|
||
| Users usually expect broadening here, because `tontrager` should still find `20220409-tontrager.xlsx`. |
| - `foo-bar` | ||
| - `20220409-tontrager.xlsx` | ||
|
|
||
| Users usually expect broadening here, because `tontrager` should still find `20220409-tontrager.xlsx`. |
Collaborator
Author
|
@niels9001 I'm adding a new item with the message instead of replacing EmptyContent with the notice -- I feel that if we put it into EmptyContent, users would dismiss it as actual empty content. Thoughts? 
|
Collaborator
@jiripolasek Yeah this works.. but can't we show empty content with an error icon instead of the File Explorer icon (that would show up in the actual empty state)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR improves File Search:
&or other symbols).Pictures? Pictures!
Error notices:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed