Skip to content

fix: Peek.UI persists as a media player after closed & redundant SMTC… #46899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zheng-fan wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix: Peek.UI persists as a media player after closed & redundant SMTC… #46899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/modules/peek/Peek.FilePreviewer/Controls/AudioControl.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ private void SourcePropertyChanged()
{
PlayerElement.MediaPlayer.Pause();
PlayerElement.MediaPlayer.Source = null;
PlayerElement.MediaPlayer.CommandManager.IsEnabled = false;
}
else
{
PlayerElement.MediaPlayer.CommandManager.IsEnabled = true;
}
}

Expand Down
7 changes: 6 additions & 1 deletion src/modules/peek/Peek.FilePreviewer/FilePreview.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ private async Task OnItemPropertyChanged()
Previewer = null;
ImagePreview.Visibility = Visibility.Collapsed;
VideoPreview.Visibility = Visibility.Collapsed;

AudioPreview.Visibility = Visibility.Collapsed;
BrowserPreview.Visibility = Visibility.Collapsed;
ArchivePreview.Visibility = Visibility.Collapsed;
Expand Down Expand Up @@ -281,6 +280,12 @@ partial void OnPreviewerChanging(IPreviewer? value)
}
}

partial void OnPreviewerChanged(IPreviewer? value)
{
// Ensure the media transport controls are only present when viewing video media.
VideoPreview.MediaPlayer.CommandManager.IsEnabled = value is IVideoPreviewer;
}

private void BrowserPreview_DOMContentLoaded(Microsoft.Web.WebView2.Core.CoreWebView2 sender, Microsoft.Web.WebView2.Core.CoreWebView2DOMContentLoadedEventArgs args)
{
/*
Expand Down
Loading