Open
Conversation
- FileLocksmith: log actual operation mode (query, kill, query-wait, query-json, help) instead of hardcoded 'filelocksmith' - ImageResizerCLICommandEvent: initialize CommandName to string.Empty for consistency with AwakeCLICommandEvent - Update DATA_AND_PRIVACY.md to document FileLocksmith operation modes - Add command_name assertions to FileLocksmith CLI tests
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new telemetry events for CLI invocations across Image Resizer, Awake, and File Locksmith, and documents the new events in the repository’s diagnostic data catalog.
Changes:
- Add managed telemetry event types for Awake and Image Resizer CLI execution.
- Emit CLI telemetry from ImageResizerCLI and FileLocksmithCLI (including command mode tracking for File Locksmith).
- Update
DATA_AND_PRIVACY.mdto document the new CLI telemetry events.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/imageresizer/ui/Cli/Telemetry/ImageResizerCLICommandEvent.cs | Adds Image Resizer CLI telemetry event payload type. |
| src/modules/imageresizer/ImageResizerCLI/Program.cs | Emits Image Resizer CLI telemetry after execution. |
| src/modules/FileLocksmith/FileLocksmithLib/Trace.h | Adds File Locksmith CLI telemetry API surface. |
| src/modules/FileLocksmith/FileLocksmithLib/Trace.cpp | Implements ETW event for File Locksmith CLI telemetry. |
| src/modules/FileLocksmith/FileLocksmithCLI/CLILogic.h | Extends command result to include a command name for telemetry. |
| src/modules/FileLocksmith/FileLocksmithCLI/CLILogic.cpp | Populates command name across CLI flows (help/query/kill/wait/json). |
| src/modules/FileLocksmith/FileLocksmithCLI/main.cpp | Registers provider and emits CLI command telemetry. |
| src/modules/FileLocksmith/FileLocksmithCLI/tests/FileLocksmithCLITests.cpp | Updates unit tests to assert the new command_name output. |
| src/modules/awake/Awake/Telemetry/AwakeCLICommandEvent.cs | Adds Awake CLI telemetry event payload type. |
| src/modules/awake/Awake/Program.cs | Attempts to emit Awake CLI telemetry on success/failure paths. |
| DATA_AND_PRIVACY.md | Documents new CLI telemetry events for Awake, File Locksmith, and Image Resizer. |
…emetry # Conflicts: # DATA_AND_PRIVACY.md
- Awake: move LogCLITelemetry before Exit() calls since Manager.CompleteExit calls Environment.Exit, making code after Exit() unreachable - ImageResizer: derive CommandName from actual operation (help, show-config, error, resize) instead of hardcoded 'resize', via new CommandName property on ImageResizerCliExecutor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR adds comprehensive localization and telemetry support to the modules with CLI (FileLocksmith, Awake, ImageResizer), improving user experience for international users and enabling usage tracking for product insights.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed