CmdPal Dock: fix snapped windows overlapping the dock surface#46864
Draft
DaveT1991 wants to merge 4 commits intomicrosoft:mainfrom
Draft
CmdPal Dock: fix snapped windows overlapping the dock surface#46864DaveT1991 wants to merge 4 commits intomicrosoft:mainfrom
DaveT1991 wants to merge 4 commits intomicrosoft:mainfrom
Conversation
The schwa (ə) is an IPA phonetic symbol, not an Italian accented letter, and is already covered by the IPA language set. The Euro sign (€) is a currency symbol and does not belong in a language-specific accent set. Italian only uses è and é as accented forms of the letter e. Fixes microsoft#46857
When loading the machine matrix, two scenarios could produce a duplicate machine slot that the user had no way to remove: 1. MachinePool stored the same machine name under multiple IDs (e.g. after a reconnect with a new ID). The available-machine list was built without deduplication, so both entries could end up racing for the same slot. 2. A matrix persisted from an earlier session already contained a duplicate name. The removal loop only checked availability against MachinePool, so the duplicate passed through and was preserved on every reload. Fix both by: - Deduplicating the available-machine list as it is built from MachinePool (case-insensitive, matching the rest of the codebase). - Tracking seen names in a HashSet while iterating the saved matrix and clearing any slot whose name has already appeared earlier. - Making all Contains comparisons case-insensitive for consistency. Fixes microsoft#46858
The window position was expanded by SM_CXFRAME on all four sides to account for the invisible DWM resize border. This caused the visible dock surface to extend frameWidth pixels past the reserved app-bar rect (_appBarData.rc). Snap layouts respect the work-area boundary set by ABM_SETPOS, which matches _appBarData.rc, so snapped windows would partially cover the dock on the side facing the work area. Fix: only expand outward on the three sides that face away from the work area (off-screen or the screen edge). The side that faces the work area is kept exactly at _appBarData.rc so snapped windows abut it cleanly. Fixes microsoft#46849
Collaborator
|
Hi @DaveT1991, |
michaeljolley
added
Product-Command Palette
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateWindowPositionexpanded the dock window bySM_CXFRAMEon allfour sides to account for the invisible DWM resize border. The side
facing the work area was also extended by
frameWidthpixels past therect registered with
ABM_SETPOS. Windows Snap layouts respect thework-area boundary (which matches
_appBarData.rc), so any snappedwindow would start right at that boundary and partially cover the
visible dock.
Fix: apply the frame expansion only on the three sides that face away
from the work area. The edge that borders the work area is kept exactly
at
_appBarData.rc, so snapped windows now abut the dock cleanly onall four dock positions (Top, Bottom, Left, Right).
Issues Fixed
Fixes #46849