CmdPal: Add support for commands with parameters#46860
CmdPal: Add support for commands with parameters#46860ChaseKnowlden wants to merge 45 commits intomicrosoft:mainfrom
Conversation
zadjii-msft
left a comment
There was a problem hiding this comment.
I don't think this is the correct approach here. There's no viewmodels to capture the state from the extension. It what, uses a ContentDialog to accept parameters?
I have a much more complete version of this spec'd and prototyped in #43784, it just needs merging with main. I'd start with that if you're interested in finishing this task.
|
I've merged their old branch. |
| These are used when the `SelectValueCommand` is an `IInvokableCommand`. | ||
|
|
||
| These are rendered as a button within the search box. The button text is | ||
| `DisplayText` if it is set, otherwise it is `PlaceholderText`. If the user |
| public void UpdateText(ISearchUpdateArgs newText) { | ||
| Text = newText.Text; | ||
| // newText may have other properties too, like a correlation vector, | ||
| // but that's not demo'd here. |
This comment has been minimized.
This comment has been minimized.
This reverts commit bce5bc9.
9ad5119 to
3f6d868
Compare
There was a problem hiding this comment.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.Unrecognized words (22)These words are not needed and should be removeddiu IPREVIEW ITHUMBNAIL LPCFHOOKPROC LUMA MAXDWORD MRT suntimes timespan VSyncTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:ChaseKnowlden/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/24314709777/attempts/1' &&
git commit -m 'Update check-spelling metadata'Forbidden patterns 🙅 (2)In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves. These forbidden patterns matched content: Should be
|
| ❌ Errors and Notices | Count |
|---|---|
| ℹ️ candidate-pattern | 3 |
| ❌ forbidden-pattern | 3 |
See ❌ Event descriptions for more information.
If the flagged items are 🤯 false positives
If items relate to a ...
-
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txtfile matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^refers to the file's path from the root of the repository, so^README\.md$would exclude README.md (on whichever branch you're using). -
well-formed pattern.
If you can write a pattern that would match it,
try adding it to thepatterns.txtfile.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
I've added support for parameters for commands requiring them.
Validation Steps Performed