Propagate sensitive Porter parameters into template registration schema#4910
Draft
Copilot wants to merge 4 commits into
Draft
Propagate sensitive Porter parameters into template registration schema#4910Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
2 tasks
Copilot
AI
changed the title
[WIP] Update handling of sensitive parameters in porter.yaml
Propagate sensitive Porter parameters into template registration schema
May 21, 2026
Collaborator
|
@copilot add enhancement note to changelog.md |
Contributor
Author
Added in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being addressed
Template sensitivity metadata was duplicated across
porter.yamlandtemplate_schema.json, creating drift and requiring manual double-entry. This change makes sensitivity authoritative in Porter metadata and propagates it into the API registration payload automatically.How is this addressed
Registration payload synthesis
devops/scripts/register_bundle_with_api.shto merge Porter sensitivity metadata intojson_schemaat registration time.porter explainoutput and applied to matching schema properties (including nestedpropertiesblocks).Template metadata migration
sensitive: truefrom affectedtemplate_schema.jsonfiles.sensitive: trueon the correspondingparametersinporter.yaml:client_secret(workspace templates)airlock_request_sas_url(guacamole review VM user resources)smtpPasswordremains in Porter forairlock_notifierPorter/Plugin compatibility confirmation
PORTER_VERSION=v1.4.0,PORTER_AZURE_PLUGIN_VERSION=v1.2.4) already include the upstream secret-name cleanup behavior needed for snake_case sensitive params; no version bump required for this issue.CHANGELOG.md: not updated in this PR.