Repository navigation
Fix broken REST API doc link in storage-speech-language README - #662
Closed
Nick Brady (nicholasdbrady) wants to merge 1 commit into
Closed
Nick Brady (nicholasdbrady) wants to merge 1 commit into
Nick Brady (nicholasdbrady) wants to merge 1 commit into
Conversation
The Foundry project connections API link pointed to /aiprojects/ (plural), which returns a 404. The correct path is /aiproject/ (singular). Caught via OCV customer feedback (ADO #5203449). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
👋 Thanks for your contribution, Nick Brady (@nicholasdbrady)! This repository is read-only. As a Microsoft contributor, please submit your PR to the private staging repository instead: See CONTRIBUTING.md for full instructions. |
foundry-samples-repo-sync Bot
pushed a commit
that referenced
this pull request
Jul 8, 2026
* ci(samples): add basic data-plane validation Run hosted-agent diagnostics after each ephemeral Bicep deployment so the ADO validation proves deployed data-plane endpoints are reachable from a hosted agent runtime. The diagnostic step discovers Foundry project endpoints, deploys the checked-in diagnostic agent into the ephemeral resource group, invokes DNS/TCP/TLS/HTTP probes, and fails the job on probe failures. Authored-by: GitHub Copilot CLI v1.0.65 Model: GPT-5.5 (gpt-5.5) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(samples): initialize diagnostic azd environment Create the azd environment explicitly before setting diagnostic deployment values so CI does not block during hosted-agent diagnostics setup. Authored-by: GitHub Copilot CLI v1.0.65 Model: GPT-5.5 (gpt-5.5) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(samples): install diagnostic azd project extension Install the azure.ai.projects azd extension before deploying the diagnostic hosted-agent project so azd can resolve the azure.ai.project service host in the checked-in sample. Authored-by: GitHub Copilot CLI v1.0.65 Model: GPT-5.5 (gpt-5.5) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test(samples): trigger private data-plane validation Add a harmless marker under the private-network standard agent sample so the ADO PR validation deploys that private sample and runs the new data-plane diagnostics against it. Authored-by: GitHub Copilot CLI v1.0.65 Model: GPT-5.5 (gpt-5.5) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(samples): prefer main bicep params in PR validation Deploy main.bicepparam for targeted or changed sample validation when present so CI validates the primary sample path instead of auxiliary add-existing-project parameter files that require external resources. Authored-by: GitHub Copilot CLI v1.0.65 Model: GPT-5.5 (gpt-5.5) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(samples): surface private validation blockers Fail deployment validation immediately when ARM deployments fail instead of continuing inside a conditional shell function. Add the missing ACR private DNS zone key for template 15 and emit an actionable diagnostic error when public access is disabled without private endpoint connectivity from the ADO runner. Authored-by: GitHub Copilot CLI v1.0.65 Model: GPT-5.5 (gpt-5.5) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * ci(samples): skip private hosted diagnostics Treat private-only Foundry samples as deploy/resource validation on Microsoft-hosted ADO agents. Hosted-agent data-plane diagnostics now skip with a warning unless private endpoint connectivity is explicitly provided, and the temporary README marker used to exercise the private sample is removed. Authored-by: GitHub Copilot CLI v1.0.65 Model: GPT-5.5 (gpt-5.5) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: kishorebr <kishorebr@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Foundry project connections API" link in the storage-speech-language Bicep README points to
/rest/api/aifoundry/aiprojects/connections(plural). That URL returns a 404.The correct path is
/rest/api/aifoundry/aiproject/connections(singular).What changed: One character in the inline link on line 7.
How I found it: A customer filed OCV feedback (ADO #5203449) reporting broken doc links after migrating to NextGen. Traced the 404 back to this README and a similar reference in azure-sdk-for-js (PR filed separately).