Repository navigation
Automated sync from private repo (2026-03-19) - #611
Merged
Merged
Conversation
…v2 (#84) Replace three per-collection azurerm_cosmosdb_sql_role_assignment resources (scoped to individual enterprise_memory collections) with a single assignment scoped at the Cosmos DB account level. This is required for Agents v2 and eliminates redundant per-collection definitions. Affected templates: - infrastructure-setup-terraform/15a-private-network-standard-agent-setup - infrastructure-setup-terraform/15b-private-network-standard-agent-setup-byovnet
aahill
approved these changes
Mar 19, 2026
Brandon Miller (brandom-msft)
deleted the
sync/private-to-public-20260319-210757
branch
March 19, 2026 21:22
Graeme (graemefoster)
pushed a commit
to graemefoster/foundry-samples
that referenced
this pull request
Jun 17, 2026
* fix: scope Cosmos DB SQL role assignment to account level for Agents v2 (microsoft-foundry#84) Replace three per-collection azurerm_cosmosdb_sql_role_assignment resources (scoped to individual enterprise_memory collections) with a single assignment scoped at the Cosmos DB account level. This is required for Agents v2 and eliminates redundant per-collection definitions. Affected templates: - infrastructure-setup-terraform/15a-private-network-standard-agent-setup - infrastructure-setup-terraform/15b-private-network-standard-agent-setup-byovnet * Update README with correct parameters for deployment (microsoft-foundry#95) * fixup: correct drift after commit replay * Update sync state to 4144add --------- Co-authored-by: geabdluca <73857153+geabdluca@users.noreply.github.com> Co-authored-by: AhmadAbdullah91 <91725950+AhmadAbdullah91@users.noreply.github.com> Co-authored-by: foundry-samples-repo-sync[bot] <foundry-samples-repo-sync[bot]@users.noreply.github.com>
foundry-samples-repo-sync Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
* Add NSG with AzureFrontDoor.Frontend outbound rule to template 18 VNet - Add network security group to the new-VNet path (modules-network-secured/vnet.bicep) with an outbound Allow rule to AzureFrontDoor.Frontend, associated to pe-subnet. - Add privatelink.azurecr.io to existingDnsZones and dnsZoneNames in main.bicepparam so the ACR private DNS zone is validated/created during deployment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Move AzureFrontDoor.Frontend rule to managed-network outbound rules The agent runs in the Microsoft-managed network, so the customer VNet NSG does not govern its egress. Remove the NSG/rule from vnet.bicep and instead add an AzureFrontDoor.Frontend service-tag outbound rule to the account's managed network, which is what actually governs hosted-agent egress to the Agent365 (A365) tracing endpoint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add A365 Front Door managed-network outbound rule to template 18 Terraform Mirror the Bicep change in the Terraform variant of template 18: add a ServiceTag managed-network outbound rule (AzureFrontDoor.Frontend, TCP 443) so the hosted agent can reach the Agent365 tracing endpoint. Chained after ampls_outbound_rule and included in the outbound-rule provisioning wait. Note: this template uses isolationMode AllowInternetOutbound, so the rule is redundant for connectivity today; it is added for parity with the Bicep template and for correctness if the mode is changed to AllowOnlyApprovedOutbound. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Document A365 tracing service-tag outbound rule in template 18 README Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated by the repo sync workflow.
Review carefully before merging. Verify no internal content was included.
Triggered by:
workflow_dispatchRun: https://github.com/microsoft-foundry/foundry-samples-pr/actions/runs/23316930682