Skip to content

Updating Csharp and python MAF samples to GA. - #1070

Merged
Mohit Pavan Kumar Gadamsetty (mohitpavan) merged 12 commits into
mainfrom
users/mohit/bat-ga-mcp-csharp-maf
Oct 15, 2026
Merged

Mohit Pavan Kumar Gadamsetty (mohitpavan) merged 12 commits into
mainfrom
users/mohit/bat-ga-mcp-csharp-maf

Conversation

@mohitpavan

@mohitpavan Mohit Pavan Kumar Gadamsetty (mohitpavan) commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Updating Csharp and Python MAF samples to GA.

[BAT-GA] Migrate C# and Python MAF browser automation samples to GA MCP.

Follow ups:
p0:
Testing. (done)
Shift BYO the remining flows to GA. (next prs) (#1074)
prompt agent MCP samples (wherever needed in this repo).
p1:
There are few places where the toolbox name etc are not in full sync, will add that sync in next prs (for now this can be considered as just the migration to GA pr.)
Scripts to bicep files.(next prs)
Check the postdeploy script error for the pww id given in the new project flow (pre-existing, but need to check once, could be transient too)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 05607f09-ad87-46b5-9b03-4a9f594b891d
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 05607f09-ad87-46b5-9b03-4a9f594b891d

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Signed URLs and user inputs can leak through shared state and logs, while existing preview deployments are not migrated.

4 open findings
What changed in this PR

Migrates the C# browser automation sample from preview/local Playwright CLI integration to GA Azure Playwright MCP tools.

Changes:

  • Replaces local CLI tools with dynamically discovered GA browser tools.
  • Updates provisioning, prompts, middleware, and documentation.
  • Adds browserSessionId and live-view handling.
File Description
utils/​Tools.cs Removes local tool factories.
utils/​Middlewares.cs Handles GA sessions and live-view links.
utils/​BrowserSession.cs Removes Playwright CLI process management.
skills/​.../​SKILL.md Documents GA browser tools.
prompts/​base.md Updates browser lifecycle guidance.
Program.cs Uses Toolbox-discovered tools exclusively.
Dockerfile Removes Node.js and Playwright CLI installation.
.env.example Removes obsolete CLI timeout configuration.
README.md Rewrites setup and usage documentation.
playwright-connection.bicep Targets the GA MCP endpoint.
setup-toolbox.sh Publishes the GA tool type on POSIX.
setup-toolbox.ps1 Publishes the GA tool type on Windows.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Live-view links are shared across concurrent sessions and exposed in application logs.

1 open finding
4 resolved since last review

🧠 Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 13, 2026 13:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Signed browser live-view URLs are written to persistent application logs in several middleware paths.

2 open findings

🧠 Review effort: Balanced

Include the Python MAF GA MCP migration, obsolete infra deletions, and both MAF model manifest updates.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 05607f09-ad87-46b5-9b03-4a9f594b891d
…amples into users/mohit/bat-ga-mcp-csharp-maf

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 05607f09-ad87-46b5-9b03-4a9f594b891d

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Python migration breaks multimodal MCP results and leaves deployment evaluation and documentation inconsistencies.

4 open findings
2 resolved since last review

🧠 Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Python streaming live-view delivery and screenshot handling are broken, while dependency regeneration and toolbox configuration remain incomplete.

4 open findings
3 resolved since last review

🧠 Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Provisioning is currently disabled by the removed Foundry providers, and Python streaming and logging contain functional and data-exposure issues.

4 open findings
3 resolved since last review

🧠 Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The cross-language runtime, middleware, dependency, and Azure provisioning migration warrants final human validation.

0 open findings

4 resolved since last review

🧠 Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The prompts leave unusable browser sessions allocated instead of attempting explicit MCP cleanup.

5 open findings

🧠 Review effort: Balanced

@mohitpavan
Mohit Pavan Kumar Gadamsetty (mohitpavan) merged commit 6f9f570 into main Oct 15, 2026
19 checks passed
@mohitpavan
Mohit Pavan Kumar Gadamsetty (mohitpavan) deleted the users/mohit/bat-ga-mcp-csharp-maf branch October 15, 2026 11:59

This branch was successfully deployed

1 active deployment
L4-validation — b540417a Deployed Oct 14, 2026 by mohitpavan via trusted #541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants