Repository navigation
Keep voice sample Starlette managed by AgentServer - #1063
Merged
Antriksh Jain (antriksh30) merged 1 commit intoOct 12, 2026
Merged
Conversation
Remove direct Starlette declarations from the hosted voice samples migrated in #1060. Starlette remains pinned transitively in each frozen lock graph through AgentServer, which stays responsible for compatibility updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ec0a8f22-0687-4209-912b-1d5f4c4263f1
Antriksh Jain (antriksh30)
deployed
to
L4-validation
October 12, 2026 10:12 — with 
GitHub Actions
Active
GitHub Actions
Active
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Runtime and test code still imports Starlette directly, so it should remain declared without an explicit version pin.
6 open findings
What changed in this PR
Removes explicit Starlette declarations so AgentServer controls compatibility while preserving resolved lockfile versions.
Changes:
- Removes Starlette from three runtime dependency lists.
- Removes Starlette from three development dependency groups.
- Updates lockfile root metadata without changing resolved Starlette packages.
| File | Description |
|---|---|
voicelive/hotel-booking.../pyproject.toml |
Removes the direct runtime declaration. |
voicelive/hotel-booking.../uv.lock |
Updates project dependency metadata. |
voicelive/hello-world.../pyproject.toml |
Removes the direct runtime declaration. |
voicelive/hello-world.../uv.lock |
Updates project dependency metadata. |
voicelive/foreground-background.../pyproject.toml |
Removes the direct runtime declaration. |
voicelive/foreground-background.../uv.lock |
Updates project dependency metadata. |
voice-agent-target-agent/basic.../pyproject.toml |
Removes the direct test dependency. |
voice-agent-target-agent/basic.../uv.lock |
Updates development dependency metadata. |
voice-agent-target-agent/langchain.../pyproject.toml |
Removes the direct test dependency. |
voice-agent-target-agent/langchain.../uv.lock |
Updates development dependency metadata. |
voice-agent-target-agent/langgraph.../pyproject.toml |
Removes the direct test dependency. |
voice-agent-target-agent/langgraph.../uv.lock |
Updates development dependency metadata. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ankit Sinha (ankitbko)
approved these changes
Oct 12, 2026
Antriksh Jain (antriksh30)
deleted the
keep-voice-starlette-agentserver-managed
branch
October 12, 2026 11:06
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv.lock; this changes dependency ownership only, not the resolved graphsValidation
uv lock --checkand frozen production export--resolve