Skip to content

Added a new sample to show how to bring your own store. - #1005

Open
Sapinder Pal Singh (sapinderpalsingh) wants to merge 29 commits into
microsoft-foundry:mainfrom
sapinderpalsingh:main
Open

Sapinder Pal Singh (sapinderpalsingh) wants to merge 29 commits into
microsoft-foundry:mainfrom
sapinderpalsingh:main

Conversation

@sapinderpalsingh

Copy link
Copy Markdown

Summary

Added a Responses protocol hosted-agent sample that demonstrates how to replace all four Foundry hosting storage extension points with custom Redis-backed implementations.

Changes

  • Implemented custom stores for:
    • Responses and conversation history
    • Agent session state
    • Workflow checkpoints
    • Function approval requests
  • Added deterministic validation tools and a hosted-agent test specification that exercises all four stores, including checkpoint restoration and human approval continuation.
  • Added azd and Foundry Toolkit configuration for local development and hosted deployment.

Sithu (sithukyaw007) pushed a commit to sithukyaw007/foundry-samples that referenced this pull request Sep 21, 2026
Document support for RFC 1918 and RFC 6598 address spaces across private network Bicep and Terraform templates, including excluded CGNAT ranges and removal of outdated region-specific Class A guidance.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@ankitbko

Copy link
Copy Markdown
Contributor

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.

@ankitbko

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.

@ankitbko

Copy link
Copy Markdown
Contributor

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The hosted-agent persistence scenario and checkpoint restoration validation must be corrected before approval.

Review effort: Lite
Findings: None

Resolved since last review (1)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

One or more issues must be addressed before approval.

Review effort: Lite
Findings: None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Checkpoint restoration is not exercised, and the requirements-only dependency layout needs documented justification.

2 open findings

🧠 Review effort: Lite


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Copilot AI lite review requested due to automatic review settings October 10, 2026 09:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The setup omits authentication needed by the deployment hooks, and the tests can pass without proving that the store validation tools ran.

3 open findings
1 resolved since last review

🧠 Review effort: Lite

Comment thread samples/python/hosted-agents/agent-framework/responses/25-custom-store/README.md Outdated
Updated README to include Azure CLI installation and authentication steps.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The combined persistence contracts, Redis deployment, and identity-access hooks need final human and live-deployment validation.

1 open finding
2 resolved since last review

🧠 Review effort: Lite

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Custom persistence, cloud provisioning, and identity-based Redis access need final human deployment validation.

1 open finding

🧠 Review effort: Lite

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

A continuation bug remains, and the distributed storage deployment and identity hooks need live human validation.

1 open finding
1 resolved since last review

🧠 Review effort: Lite

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

An unresolved history-ordering issue remains, and the new persistence and cloud identity setup need human end-to-end validation.

0 open findings

1 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Medium severity Recreated responses retain stale conversation ordering

samples/​python/​hosted-agents/​agent-framework/​responses/​26-custom-store/​src/​agent-framework-agent-custom-store-responses/​redis_response_store.py:154

create_response accepts a deleted response ID, but NX leaves its old conversation score unchanged. If response A is deleted, response B is created, and A is recreated, get_history_item_ids reads A before B even though A is newer, giving the agent history in the wrong order. Give the recreated ID its new sequence score and remove its old conversation membership if the conversation changed.

🧠 Review effort: Lite

This branch was successfully deployed

1 active deployment
L4-validation — f6d9754a Deployed Oct 15, 2026 by sapinderpalsingh via trusted #556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants