Skip to content

Improve feature separation #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JKingweb wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Improve feature separation #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2dda742
Move implied-name nested control cases out to separate file
JKingweb May 1, 2026
7b77918
Remove three cases from implied-photo which are actually testing impl…
JKingweb May 1, 2026
505298f
Avoid interactions with date normalization when testing property-name…
JKingweb May 1, 2026
30e1b97
Don't rely on incidental HTML parsing behaviour when testing implied-url
JKingweb May 1, 2026
dcad7e4
Avoid testing blank implied names when testing implied-url
JKingweb May 1, 2026
13979e4
Avoid unnecessary blank implied name when testing implied-photo
JKingweb May 2, 2026
b771d33
Move implied-photo nested microformat cases out to separate file
JKingweb May 2, 2026
edf407b
Move implied-url nested microformat cases out to separate file
JKingweb May 2, 2026
958bfc6
Add terminal whitespace for consistency
JKingweb May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions tests/microformats-v2-unit/implied/implied-name.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
trimming is performed.
-->

<!-- Control tests: implied name does not apply in these cases -->
<!--
Control tests: implied name does not apply in these cases.
Also not applicable are cases where there is a nested microformat, but this
is tested in a separate file due to the extra complexity involved.
-->
<div class="h-test-explicit">
<div class="dt-name">Valid</div> Invalid
</div>
Expand All @@ -18,17 +22,7 @@
<div class="e-override">NotPartOfTest</div> Invalid
</div>

<div class="h-test-nested">
<div class="h-test-child">
<div class="p-name">NotPartOfTest</div> Invalid
</div> Invalid
</div>

<div class="h-test-nested-prop">
<div class="h-test-child dt-prop">NotPartOfTest<span class="p-name">NotPartOfTest</span></div> Invalid
</div>

<!-- Simple tests -->
<!-- Simple tests; note that these do not imply photos or URLs because there are no "src" or "href" attributes -->
<img class="h-test-img-filled" alt="Valid">
<img class="h-test-img-filled-space" alt=" Do Trim ">
<img class="h-test-img-empty" alt="">
Expand Down
38 changes: 0 additions & 38 deletions tests/microformats-v2-unit/implied/implied-name.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,44 +33,6 @@
]
}
},
{
"type": [
"h-test-nested"
],
"properties": {},
"children": [
{
"type": [
"h-test-child"
],
"properties": {
"name": [
"NotPartOfTest"
]
}
}
]
},
{
"type": [
"h-test-nested-prop"
],
"properties": {
"prop": [
{
"value": "NotPartOfTestNotPartOfTest",
"type": [
"h-test-child"
],
"properties": {
"name": [
"NotPartOfTest"
]
}
}
]
}
},
{
"type": [
"h-test-img-filled"
Expand Down
20 changes: 3 additions & 17 deletions tests/microformats-v2-unit/implied/implied-photo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@
aspect of these tests, but resolution complexity is kept to a minimum.
-->

<img class="h-test-img-src-missing-alt-missing">
<img class="h-test-img-src-missing-alt-empty" alt="">
<img class="h-test-img-src-missing-alt-filled" alt="NameOnly">
<img class="h-test-img-src-missing-alt-filled-space" alt=" NameOnly ">
<img class="h-test-img-src-missing" alt="Name">
<img class="h-test-img-src-empty-alt-missing" src="">
<img class="h-test-img-src-empty-alt-empty" src="" alt="">
<img class="h-test-img-src-empty-alt-filled" src="" alt="Valid">
Expand All @@ -26,14 +23,10 @@
<object class="h-test-object-data-missing">Name</object>
<object class="h-test-object-data-empty" data="">Name</object>
<object class="h-test-object-data-filled" data="http://example.test/Valid">Name</object>
<object class="h-test-object-data-filled-has-child" data="http://example.test/Invalid"><div class="h-test-child">NotPartOfTest</div></object>
<object class="h-test-object-data-filled-has-u" data="http://example.test/Invalid"><div class="u-override">http://exaple.test/NotPartOfTest</div></object>
<object class="h-test-object-data-filled-has-photo" data="http://example.test/Invalid"><div class="p-photo">Valid</div></object>

<div class="h-test-img-onlychildoftype-src-missing-alt-missing"><img></div>
<div class="h-test-img-onlychildoftype-src-missing-alt-empty"><img alt=""></div>
<div class="h-test-img-onlychildoftype-src-missing-alt-filled"><img alt="NameOnly"></div>
<div class="h-test-img-onlychildoftype-src-missing-alt-filled-space"><img alt=" NameOnly "></div>
<div class="h-test-img-onlychildoftype-src-missing"><img alt="Name"></div>
<div class="h-test-img-onlychildoftype-src-empty-alt-missing"><img class="p-name" src=""></div>
<div class="h-test-img-onlychildoftype-src-empty-alt-empty"><img src="" alt=""></div>
<div class="h-test-img-onlychildoftype-src-empty-alt-filled"><img src="" alt="Valid"></div>
Expand All @@ -46,7 +39,6 @@
<div class="h-test-img-onlychildoftype-type-sibling-after"><img src="http://example.test/Invalid" class="p-name"><img></div>
<div class="h-test-img-onlychildoftype-nontype-sibling-before"><hr><img class="p-name" src="http://example.test/Valid"></div>
<div class="h-test-img-onlychildoftype-nontype-sibling-after"><img class="p-name" src="http://example.test/Valid"><hr></div>
<div class="h-test-img-onlychildoftype-has-child"><img class="h-test-child p-name" src="http://example.test/ChildOnly"></div>
<div class="h-test-img-onlychildoftype-has-u"><img class="u-override p-name" src="http://example.test/NotPartOfTest"></div>
<div class="h-test-img-onlychildoftype-has-photo"><img class="p-photo" src="http://example.test/Invalid"></div>
<object class="h-test-img-onlychildoftype-root-object"><img class="p-name" src="http://example.test/Valid"></object>
Expand All @@ -60,17 +52,13 @@
<div class="h-test-object-onlychildoftype-type-sibling-after"><object data="http://example.test/Invalid"></object><object>Name</object></div>
<div class="h-test-object-onlychildoftype-nontype-sibling-before"><hr><object data="http://example.test/Valid">Name</object></div>
<div class="h-test-object-onlychildoftype-nontype-sibling-after"><object data="http://example.test/Valid">Name</object><hr></div>
<div class="h-test-object-onlychildoftype-has-child"><object data="http://example.test/Invalid"><div class="h-test-child">NotPartOfTest</div></object></div>
<div class="h-test-object-onlychildoftype-has-u"><object data="http://example.test/NotPartOfTest"><div class="u-override">http://example.test/NameAndOverride</div></object></div>
<div class="h-test-object-onlychildoftype-has-photo"><object data="http://example.test/Invalid"><div class="p-photo">Valid</div></object></div>
<object class="h-test-object-onlychildoftype-root-object"><object data="http://example.test/Valid">Name</object></object>
<object class="h-test-object-onlychildoftype-root-object-with-data" data="http://example.test/Valid"><object data="http://example.test/Invalid" class="p-name">Name</object></object>
<object class="h-test-object-onlychildoftype-root-object-with-data-empty" data=""><object data="http://example.test/Invalid" class="p-name">Name</object></object>

<div class="h-test-img-onlygrandchildoftype-src-missing-alt-missing"><div><img></div></div>
<div class="h-test-img-onlygrandchildoftype-src-missing-alt-empty"><div><img alt=""></div></div>
<div class="h-test-img-onlygrandchildoftype-src-missing-alt-filled"><div><img alt="NameOnly"></div></div>
<div class="h-test-img-onlygrandchildoftype-src-missing-alt-filled-space"><div><img alt=" NameOnly "></div></div>
<div class="h-test-img-onlygrandchildoftype-src-missing"><div><img alt="Name"></div></div>
<div class="h-test-img-onlygrandchildoftype-src-empty-alt-missing"><div><img class="p-name" src=""></div></div>
<div class="h-test-img-onlygrandchildoftype-src-empty-alt-empty"><div><img src="" alt=""></div></div>
<div class="h-test-img-onlygrandchildoftype-src-empty-alt-filled"><div><img src="" alt="Valid"></div></div>
Expand All @@ -85,7 +73,6 @@
<div class="h-test-img-onlygrandchildoftype-nontype-sibling-after"><div><img class="p-name" src="http://example.test/Valid"><hr></div></div>
<div class="h-test-img-onlygrandchildoftype-parent-sibling-before"><hr><div><img src="http://example.test/Invalid" class="p-name"></div></div>
<div class="h-test-img-onlygrandchildoftype-parent-sibling-after"><div><img src="http://example.test/Invalid" class="p-name"></div><hr></div>
<div class="h-test-img-onlygrandchildoftype-has-child"><div><img class="h-test-child p-name" src="http://example.test/ChildOnly"></div></div>
<div class="h-test-img-onlygrandchildoftype-has-u"><div><img class="u-override p-name" src="http://example.test/NotPartOfTest"></div></div>
<div class="h-test-img-onlygrandchildoftype-has-photo"><div><img class="p-photo" src="http://example.test/Invalid"></div></div>
<object class="h-test-img-onlygrandchildoftype-root-object"><div><img class="p-name" src="http://example.test/Valid"></div></object>
Expand All @@ -101,7 +88,6 @@
<div class="h-test-object-onlygrandchildoftype-nontype-sibling-after"><div><object data="http://example.test/Valid">Name</object><hr></div></div>
<div class="h-test-object-onlygrandchildoftype-parent-sibling-before"><hr><div><object data="http://example.test/Invalid">Name</object></div></div>
<div class="h-test-object-onlygrandchildoftype-parent-sibling-after"><div><object data="http://example.test/Invalid">Name</object></div><hr></div>
<div class="h-test-object-onlygrandchildoftype-has-child"><div><object data="http://example.test/Invalid"><div class="h-test-child">NotPartOfTest</div></object></div></div>
<div class="h-test-object-onlygrandchildoftype-has-u"><div><object data="http://example.test/NotPartOfTest"><div class="u-override">http://example.test/NameAndOverride</div></object></div></div>
<div class="h-test-object-onlygrandchildoftype-has-photo"><div><object data="http://example.test/Invalid"><div class="p-photo">Valid</div></object></div></div>
<object class="h-test-object-onlygrandchildoftype-root-object"><div><object data="http://example.test/Valid">Name</object></div></object>
Expand Down
Loading