Remove editor-not-ready reload on app resume#920
Merged
Conversation
- The resume handler reloaded the app when the editor wasn't ready. It was recovery for an editor loading issue that has since been fixed, so it's no longer needed. - It also broke deep links: on a warm-start deep link, appUrlOpen navigates to the target route and resume fires right after, so the reload raced the navigation and reset the app to the home page. Removing it fixes the intermittent "opens the app but doesn't navigate" behaviour.
|
Preview build will be at |
|
Ah, OK so we think #888 is the whole story and there's no "putting the app into the background prevents MakeCode from loading" problem? Maybe just made it more likely to hit the sim timing issue? |
Author
Yes, couldn't repro the issue of the editor not loading and the XCode logcat seems to show the workspace getting loaded even when the app is in the background.
Yes, I think it is this. |
microbit-matt-hillsdon
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resume handler reloaded the app when the editor wasn't ready. It was a recovery for a MakeCode editor loading issue (#765) that has since been fixed (via #888), so it's no longer needed (tested on iPad to ensure it is not needed).
The resume handler also occasionally broke deep links: on a warm-start deep link, appUrlOpen navigates to the target route and "resume" fires right after. If MakeCode is not ready, the resume causes a reload, which races the navigation and resets the app to the home page. This issue can be reproduced by opening the app, quickly pressing a project idea card to open it in the browser, and then quickly pressing "Open in CreateAI" to return to the app. Removing the resume handler fixes the issue where the app opens, but doesn't navigate to the /import page.