Skip to content

TypeScript 6 compatibility #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgieseke wants to merge 6 commits into
base: main
Choose a base branch
from
+75 −56
Open

TypeScript 6 compatibility #393

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7ecd534
Update Svelte packages
rgieseke Apr 13, 2026
6c1f65a
Remove TypeScript 5 peer dependency and update to 6
rgieseke Apr 13, 2026
e04b3da
Update Action versions and use same Playwright image version
rgieseke Apr 13, 2026
12fd6ab
Pin npm version more specific
rgieseke Apr 13, 2026
fe92aa5
Remove npm pin
rgieseke Apr 13, 2026
68585cc
Update deprecated upload-artifact action version
rgieseke Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 64 additions & 42 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 7 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
"devDependencies": {
"@playwright/test": "^1.56.1",
"@rollup/plugin-dsv": "^3.0.5",
"@sveltejs/adapter-static": "^3.0.8",
"@sveltejs/kit": "^2.22.5",
"@sveltejs/package": "^2.3.11",
"@sveltejs/adapter-static": "^3.0.10",
"@sveltejs/kit": "^2.57.1",
"@sveltejs/package": "^2.5.7",
"@sveltejs/vite-plugin-svelte": "^6.1.0",
"@types/d3": "^7.4.3",
"@types/d3-sankey": "^0.12.4",
Expand Down Expand Up @@ -62,10 +62,10 @@
"publint": "^0.3.12",
"regl": "^2.1.1",
"sanitize-html": "^2.17.0",
"svelte": "^5.35.6",
"svelte-check": "^4.2.2",
"svelte": "^5.55.3",
"svelte-check": "^4.4.6",
"topojson-client": "^3.1.0",
"typescript": "^5.8.3",
"typescript": "^6.0.2",
"underscore": "^1.13.7",
"vite": "^7.0.6",
"yootils": "^0.3.1"
Expand All @@ -91,8 +91,7 @@
"node": "^20.17.0 || >=22.9.0"
},
"peerDependencies": {
"svelte": ">=5",
"typescript": "^5.0.2"
"svelte": ">=5"
},
Comment on lines 90 to 95
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engines.node currently allows Node ^20.17.0 || >=22.9.0, but the updated toolchain in this PR pulls in Vite 7.x which requires Node ^20.19.0 || >=22.12.0 (per package-lock.json). This mismatch can cause installs to fail under engine-strict setups or mislead users about supported Node versions. Consider bumping the engine range to match the strictest dependency requirement (or pinning Vite/@sveltejs/vite-plugin-svelte to versions compatible with the current engine range).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@rgieseke rgieseke Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sveltekit has

"engines": {
	"node": ">=18.13"
}

Maybe we don't need to pin node anymore in Layer Cake?

"svelte": "./dist/index.js"
}
Loading