Fix ElvUI 12.1 profile exports - #55
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a3be5b4c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local private = loadingAddonNamespace.GetLibAddonProfilesInternal and loadingAddonNamespace:GetLibAddonProfilesInternal() | ||
| if (not private) then return end | ||
| local EXPORT_PREFIX = "!E1!" | ||
| local EXPORT_PREFIX = "!E2!" |
There was a problem hiding this comment.
When ElvUI v15.19 produces an E2 account-settings or aura-filter export, Creator cannot recognize it: load.xml still loads ElvUIGlobal.lua and ElvUIAuraFilters.lua, but both modules retain EXPORT_PREFIX = "!E1!" even though their shared Distributor:GetProfileExport now emits E2 strings. Consequently those profiles can be exported but fail testImport; apply the E2 format/version migration to every loaded ElvUI export module rather than only the main and private-profile modules.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
forgot elvui has 4 profiles...
2 participants
Summary
!E1!to!E2!v15.19Why
ElvUI development commit
0e3685c4replaced AceSerializer and LibDeflate exports withC_EncodingUtil. That removedDistributor:Serialize, causing WagoUI private-profile exports to error and changing every ElvUI export prefix to E2.Important
Do not merge this PR until ElvUI publishes a new release containing the E2/
C_EncodingUtilexport change. The latest published ElvUI tag is currentlyv15.18;v15.19is an expected future version gate, not a published release.Impact
WagoUI supports the new ElvUI E2 profile format only. Existing stable ElvUI versions remain below the new minimum version.