Eliminate toarray() for spectral/spatial metrics#1719
Open
Eliminate toarray() for spectral/spatial metrics#1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #1718 . The annotation pipeline sometimes crashes with OOM on datasets where spectra form isolated blobs inside a large bounding box. After #1718 fixed
chaos_metric, the remaining crash point isformula_validator.pywhich still materialises the full h×w dense array for every peak of every formula when building iso_imgs_flat.Change
imzml_readergets apixel_to_flat_idxlookup table built once at init — maps any pixel coordinate directly to its position in themasked-flat metrics array.
formula_validator.pyuses it to scatter sparsecoovalues directly into a 1D array of sizen_spectra, removing thetoarray()call and the intermediate denseiso_imgslist entirely.pipeline.pylogs a warning when pixel density is below 5% so blob datasets are visible in logs.