Skip to content

Fix FDR formula #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bisho2122 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix FDR formula #1477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion metaspace/engine/sm/engine/annotation/fdr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ def score_to_fdr_map(
cumulative_targets = cumulative_targets + 1
cumulative_decoys = cumulative_decoys + 1

fdrs = cumulative_decoys / decoy_ratio / cumulative_targets
weighted_decoys = cumulative_decoys / decoy_ratio
fdrs = weighted_decoys / (cumulative_targets + weighted_decoys)
fdrs[cumulative_targets == 0] = 1 # Fix NaNs when decoys come before targets

if monotonic:
Expand Down