Removing CHNOPS adducts from decoy pool#1466
Open
Bisho2122 wants to merge 1 commit intometaspace2020:masterfrom
Open
Removing CHNOPS adducts from decoy pool#1466Bisho2122 wants to merge 1 commit intometaspace2020:masterfrom
Bisho2122 wants to merge 1 commit intometaspace2020:masterfrom
Conversation
Having CHNOPS based adducts will increase the chance for a generated decoy ion to be isomeric or isobaric to an ion of a real molecule. As this affects the FDR calculation, it's important to remove those adducts from the decoy selection pool.
Contributor
|
@theodev Look at this PR from the point of view of science. I think we should regenerate all |
sergii-mamedov
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having CHNOPS based adducts will increase the chance for a generated decoy ion to be isomeric or isobaric to an ion of a real molecule. As this affects the FDR calculation, it's important to remove those adducts from the decoy selection pool.