fix: report failed installations to metal-api instead of skipping the report - #189
Closed
GeertJohan wants to merge 1 commit into
Closed
GeertJohan wants to merge 1 commit into
GeertJohan wants to merge 1 commit into
Conversation
… report The installation report was skipped entirely when the installation failed (the old FIXME): metal-api never learned Success=false or the error message, even though the report plumbing fully supports it (InstallError -> Success, Message). Now the report is always attempted; a failed installation still fails installImage, and a failed report upload is joined onto the installation error.
Author
|
Superceded by #190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installation report was skipped entirely when the installation failed (the old FIXME): metal-api never learned Success=false or the error message, even though the report plumbing fully supports it (InstallError -> Success, Message). Now the report is always attempted; a failed installation still fails installImage, and a failed report upload is joined onto the installation error.