fix What's up with django-models-utils #2328 by asukaminato0721 · Pull Request #4695 · meta/pyrefly

asukaminato0721 · 2026-08-27T19:27:15Z

Summary

now preserves explicitly assigned Django manager types, so django-model-utils APIs such as InheritanceManager.select_subclasses() remain available and correctly specialize to the model type.

Test Plan

add test

meta-codesync · 2026-10-28T10:53:14Z

This pull request has been imported. If you are a Meta employee, you can view this in D128046245. (Because this pull request was imported automatically, there will not be any future comments.)

stroxler

Thanks!

An initial round of AI review flagged a few issues we should address before we consider merging:

Valid inherited-manager replacements fail

[class_field.rs:3295–3313](

pyrefly/pyrefly/lib/alt/class/class_field.rs

Lines 3295 to 3313 in 3dd5577

    
           let hinted_ty = self.attribute_expr_infer( 
        
               e, 
        
               Some(&Annotation::new_type(inherited_ty.clone())), 
        
               name, 
        
               &errors2, 
        
           ); 
        
           if !errors2.has_hard() { 
        
               // The new type is compatible with the inherited one; use the child's 
        
               // inferred type to preserve type precision. Skip the override check 
        
               // since we've already validated compatibility above. 
        
               is_inherited = IsInherited::No; 
        
               if is_django_manager_assignment { 
        
                   hinted_ty 
        
               } else { 
        
                   self.attribute_expr_infer(e, None, name, errors) 
        
               } 
        
           } else { 
        
               // The hint was no good; infer the type without it. 
        
               self.attribute_expr_infer(e, None, name, errors)

)

class Parent(models.Model):
    objects = InheritanceManager()

class Child(Parent):
    objects = models.Manager()

The parent revision infers Manager[Child]. The PR emits bad-override-mutable-attribute, infers Manager[Unknown], and makes Child.objects.get() return Unknown.

The hint now comes from the parent’s concrete manager type, which a plain or sibling manager cannot satisfy. Django permits these replacements and rebinds the manager to the child model.

Bare custom managers lose model specialization

[class_field.rs:3306–3307](

pyrefly/pyrefly/lib/alt/class/class_field.rs

Lines 3306 to 3307 in 3dd5577

    
           if is_django_manager_assignment { 
        
               hinted_ty

)

For the common pattern class PersonManager(models.Manager) followed by Person.objects = PersonManager() in the class body:

get() and create() change from Person to Unknown.
filter() changes from QuerySet[Person] to QuerySet[Unknown].

Custom methods become available, but built-in manager methods lose their model type. The new test covers only a generic manager, so it misses this tradeoff.

Clearing the annotation also discards `ClassVar`

[class_field.rs:3246–3251](

pyrefly/pyrefly/lib/alt/class/class_field.rs

Lines 3246 to 3251 in 3dd5577

    
           let is_django_manager_assignment = direct_annotation.is_none() 
        
               && matches!(value, ExprOrBinding::Expr(_)) 
        
               && self.get_metadata_for_class(class).is_django_model() 
        
               && name.as_str() == "objects"; 
        
           if is_django_manager_assignment { 
        
               inherited_annotation = None;

)

This affects even objects = models.Manager():

An instance assignment to objects, previously rejected as read-only, is accepted.
Passing the model class to a protocol declaring objects: Manager[Any], previously accepted, produces bad-argument-type.

The fix should preserve inherited qualifiers while separating model specialization from the concrete manager type and override checks.

Validation: compared independently built parent/head binaries on macOS; checked real django-model-utils 5.0.0 and Django 5.2.7 runtime behavior. No full-suite rerun, PR comments, or code changes.

Local source

ow preserves explicitly assigned Django manager types, so django-model-utils APIs such as InheritanceManager.select_subclasses() remain available and correctly specialize to the model type.

github-actions · 2026-11-03T03:10:06Z

Diff from mypy_primer, showing the effect of this PR on open source code:

============================================================
SUMMARY
============================================================
Total: +20 new errors, -2420 fixed errors
By preset: +1/-1 (default), +1/-1 (strict)

Projects with changes (1):
  zulip: +20 -2420
============================================================

FULL DIFF DETAILS
------------------------------------------------------------

zulip (https://github.com/zulip/zulip)
- ERROR analytics/views/stats.py:63:23-42: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR analytics/views/stats.py:63:35-42: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR analytics/views/stats.py:63:43-49: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR analytics/views/stats.py:63:49-65:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR analytics/views/stats.py:65:11-16: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR analytics/views/stats.py:65:16-18: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:162:9-28: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:162:21-28: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:162:29-35: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:162:35-78: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:163:10-17: The type of attribute `exclude` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:163:17-46: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:164:10-15: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:164:15-17: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:170:12-31: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:170:24-31: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:170:32-38: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:170:38-172:6: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:172:7-12: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/stripe.py:172:12-14: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:537:13-25: The type of `user_profile` is unknown; it is inferred as an implicit `Any` [unknown-variable-type]
- ERROR corporate/lib/test_stripe_class.py:537:29-48: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:537:41-48: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:537:49-55: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:537:55-74: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:537:75-82: The type of attribute `exclude` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:537:82-539:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:540:32-44: The type of this argument is unknown [unknown-argument-type]
- ERROR corporate/lib/test_stripe_class.py:544:13-32: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:544:25-32: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:544:33-39: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:544:39-68: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:544:69-74: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:544:74-76: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:551:13-32: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:551:25-32: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:551:33-40: The type of attribute `exclude` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:551:40-53: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:551:54-60: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:551:60-76: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:551:77-82: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/lib/test_stripe_class.py:551:82-84: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_activity_views.py:129:13-34: The type of `activity_user_profile` is unknown; it is inferred as an implicit `Any` [unknown-variable-type]
- ERROR corporate/tests/test_activity_views.py:129:38-57: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_activity_views.py:129:50-57: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_activity_views.py:129:58-61: The type of attribute `all` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_activity_views.py:129:61-63: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_activity_views.py:129:64-72: The type of attribute `iterator` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_activity_views.py:129:72-74: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_activity_views.py:131:17-51: The type of this argument is unknown [unknown-argument-type]
+ ERROR corporate/tests/test_stripe.py:2147:9-2152:10: Result of call expression is of type `UserProfile` and is not used; assign to `_` if this is intentional [unused-call-result]
+ ERROR corporate/tests/test_stripe.py:2156:9-2158:10: Result of call expression is of type `UserProfile` and is not used; assign to `_` if this is intentional [unused-call-result]
+ ERROR corporate/tests/test_stripe.py:2160:13-2165:14: Result of call expression is of type `UserProfile` and is not used; assign to `_` if this is intentional [unused-call-result]
+ ERROR corporate/tests/test_stripe.py:2168:9-2173:10: Result of call expression is of type `UserProfile` and is not used; assign to `_` if this is intentional [unused-call-result]
- ERROR corporate/tests/test_stripe.py:2128:17-36: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2128:17-2130:10: The type of `user1` is unknown; it is inferred as an implicit `Any` [unknown-variable-type]
- ERROR corporate/tests/test_stripe.py:2128:29-36: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2128:37-43: The type of attribute `create` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2128:43-2130:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2131:17-36: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2131:17-2133:10: The type of `user2` is unknown; it is inferred as an implicit `Any` [unknown-variable-type]
- ERROR corporate/tests/test_stripe.py:2131:29-36: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2131:37-43: The type of attribute `create` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2131:43-2133:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2138:15-19: The type of attribute `save` is unknown; it is inferred as an implicit `Any` [unknown-attribute-access]
- ERROR corporate/tests/test_stripe.py:2142:28-33: The type of this argument is unknown [unknown-argument-type]
- ERROR corporate/tests/test_stripe.py:2147:9-28: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2147:21-28: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2147:29-35: The type of attribute `create` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2147:35-2152:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2156:9-28: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2156:21-28: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2156:29-35: The type of attribute `create` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2156:35-2158:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2160:13-32: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2160:25-32: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2160:33-39: The type of attribute `create` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2160:39-2165:14: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2168:9-28: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2168:21-28: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2168:29-35: The type of attribute `create` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:2168:35-2173:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3840:24-43: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3840:24-3844:18: The type of `user` is unknown; it is inferred as an implicit `Any` [unknown-variable-type]
- ERROR corporate/tests/test_stripe.py:3840:36-43: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3840:44-50: The type of attribute `create` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3840:50-3844:18: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3845:23-29: The type of attribute `append` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3845:29-35: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3845:30-34: The type of this argument is unknown [unknown-argument-type]
- ERROR corporate/tests/test_stripe.py:3847:20-28: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3847:20-28: The type of `user` is unknown; it is inferred as an implicit `Any` [unknown-variable-type]
- ERROR corporate/tests/test_stripe.py:3849:18-22: The type of attribute `save` is unknown; it is inferred as an implicit `Any` [unknown-attribute-access]
- ERROR corporate/tests/test_stripe.py:3853:55-63: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3853:55-63: The type of this argument is unknown [unknown-argument-type]
- ERROR corporate/tests/test_stripe.py:3960:29-48: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3960:29-71: The type of `recipient` is unknown; it is inferred as an implicit `Any` [unknown-variable-type]
- ERROR corporate/tests/test_stripe.py:3960:41-48: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3960:49-52: The type of attribute `get` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3960:52-71: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe.py:3961:30-35: The type of attribute `realm` is unknown; it is inferred as an implicit `Any` [unknown-attribute-access]
- ERROR corporate/tests/test_stripe_remote_realm.py:148:28-47: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:148:40-47: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:148:48-54: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:148:54-150:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:150:11-16: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:150:16-18: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:403:32-51: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:403:44-51: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:403:52-58: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:403:58-405:14: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:405:15-20: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:405:20-22: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:622:28-47: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:622:40-47: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:622:48-54: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:622:54-624:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:624:11-16: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:624:16-18: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1756:28-47: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1756:40-47: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1756:48-54: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1756:54-1758:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1758:11-16: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1758:16-18: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1804:28-47: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1804:40-47: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1804:48-54: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1804:54-1806:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1806:11-16: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1806:16-18: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1978:28-47: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1978:40-47: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1978:48-54: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1978:54-1980:10: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1980:11-16: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_realm.py:1980:16-18: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:187:29-48: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:187:41-48: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:187:49-55: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:187:55-85: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:187:86-91: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:187:91-93: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:488:32-51: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:488:44-51: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:488:52-58: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:488:58-88: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:488:89-94: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:488:94-96: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:709:29-48: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:709:41-48: The type of attribute `objects` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:709:49-55: The type of attribute `filter` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:709:55-85: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:709:86-91: The type of attribute `count` is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:709:91-93: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]
- ERROR corporate/tests/test_stripe_remote_server.py:1384:29-48: The type of this argument is partially unknown; it contains an implicit `Any` [partially-unknown-type]

... (truncated 2284 lines) ...

stroxler

Review automatically exported from Phabricator review in Meta.

meta-codesync · 2026-11-03T17:41:30Z

This pull request has been merged in 4095f16.

meta-cla Bot added the cla signed label Aug 27, 2026

github-actions Bot added the size/s label Aug 27, 2026

This comment has been minimized.

Sign in to view

github-actions Bot assigned maggiemoss Aug 28, 2026

github-actions Bot requested a review from maggiemoss August 28, 2026 12:56

This comment has been minimized.

Sign in to view

github-actions Bot added the stale label Sep 12, 2026

asukaminato0721 force-pushed the 2328 branch from ec0a4e4 to 3dd5577 Compare October 28, 2026 10:48

github-actions Bot added size/s and removed size/s labels Oct 28, 2026

This comment has been minimized.

Sign in to view

github-actions Bot added the waiting-for-reviewer label Oct 29, 2026

rchen152 added size/xs and removed stale size/s labels Oct 30, 2026

stroxler assigned stroxler and unassigned maggiemoss Nov 2, 2026

stroxler requested changes Nov 2, 2026

View reviewed changes

github-actions Bot added waiting-for-author and removed waiting-for-reviewer labels Nov 2, 2026

asukaminato0721 force-pushed the 2328 branch from 3dd5577 to 4ed1558 Compare November 2, 2026 19:58

github-actions Bot added size/m and removed size/xs labels Nov 2, 2026

asukaminato0721 added 2 commits November 3, 2026 11:46

test

bff57de

ow preserves explicitly assigned Django manager types, so django-model-utils APIs such as InheritanceManager.select_subclasses() remain available and correctly specialize to the model type.

fix

6037e70

asukaminato0721 force-pushed the 2328 branch from 4ed1558 to 6037e70 Compare November 3, 2026 02:46

github-actions Bot added size/m and removed size/m labels Nov 3, 2026

asukaminato0721 requested a review from stroxler November 3, 2026 03:34

github-actions Bot added waiting-for-reviewer and removed waiting-for-author labels Nov 3, 2026

stroxler approved these changes Nov 3, 2026

View reviewed changes

github-actions Bot added waiting-for-merge and removed waiting-for-reviewer labels Nov 3, 2026

meta-codesync Bot closed this in 4095f16 Nov 3, 2026

meta-codesync Bot added the Merged label Nov 3, 2026

github-actions Bot removed the waiting-for-merge label Nov 3, 2026

Navigation Menu

Repository navigation

fix What's up with django-models-utils #2328 - #4695

fix What's up with django-models-utils #2328#4695
asukaminato0721 wants to merge 2 commits into
meta:mainfrom
asukaminato0721:2328

asukaminato0721 commented Aug 27, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

meta-codesync Bot commented Oct 28, 2026

Uh oh!

This comment has been minimized.

stroxler left a comment

Uh oh!

github-actions Bot commented Nov 3, 2026

Uh oh!

stroxler left a comment

Uh oh!

meta-codesync Bot commented Nov 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	let hinted_ty = self.attribute_expr_infer(
	e,
	Some(&Annotation::new_type(inherited_ty.clone())),
	name,
	&errors2,
	);
	if !errors2.has_hard() {
	// The new type is compatible with the inherited one; use the child's
	// inferred type to preserve type precision. Skip the override check
	// since we've already validated compatibility above.
	is_inherited = IsInherited::No;
	if is_django_manager_assignment {
	hinted_ty
	} else {
	self.attribute_expr_infer(e, None, name, errors)
	}
	} else {
	// The hint was no good; infer the type without it.
	self.attribute_expr_infer(e, None, name, errors)

	let is_django_manager_assignment = direct_annotation.is_none()
	&& matches!(value, ExprOrBinding::Expr(_))
	&& self.get_metadata_for_class(class).is_django_model()
	&& name.as_str() == "objects";
	if is_django_manager_assignment {
	inherited_annotation = None;

Conversation

asukaminato0721 commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

This comment has been minimized.

This comment has been minimized.

meta-codesync Bot commented Oct 28, 2026

Uh oh!

This comment has been minimized.

stroxler left a comment

Choose a reason for hiding this comment

Valid inherited-manager replacements fail

Bare custom managers lose model specialization

Clearing the annotation also discards ClassVar

Uh oh!

github-actions Bot commented Nov 3, 2026

Uh oh!

stroxler left a comment

Choose a reason for hiding this comment

Uh oh!

meta-codesync Bot commented Nov 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

asukaminato0721 commented Aug 27, 2026 •

edited

Loading

Clearing the annotation also discards `ClassVar`