xsimd: add 14.2.0#2705
Open
Alvaro-Kothe wants to merge 6 commits into
Open
Conversation
8c96165 to
5bb24c6
Compare
bgilbert
reviewed
Mar 22, 2026
5bb24c6 to
84fc001
Compare
bgilbert
reviewed
Mar 22, 2026
| option( | ||
| 'xtl_complex', | ||
| type: 'feature', | ||
| value: 'disabled', |
Collaborator
There was a problem hiding this comment.
Presumably this should default to auto? In which case, you can just remove this line.
Author
There was a problem hiding this comment.
I don't have enough knowledge on xsimd to make this decision. I mainly adapted their cmake config to meson.
Author
There was a problem hiding this comment.
Removed this line to maintain consistency with xtensor, which uses auto with xsimd.
I also added the cpp_std=c++14 that I forgot.
bgilbert
reviewed
Mar 22, 2026
| xsimd_inc = include_directories('include') | ||
| xtl_dep = dependency( | ||
| 'xtl', | ||
| version: ['>=0.7.0', '<1.0.0'], |
Collaborator
There was a problem hiding this comment.
Is an upcoming 1.0 known to break xsimd? If not, we usually don't declare the upper bound.
Author
There was a problem hiding this comment.
I don't think so. removed.
84fc001 to
11bdb89
Compare
d72b8cd to
2b5b0d8
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.