Open
Conversation
|
|
github-actions
bot
added
needs-review
Member
|
I've added a patch at #10112 to update variants that should exclude LR2021, so they won't be affected by this new support. |
Member
|
This looks good to me. In #contributors-lounge on discord I've requested anyone with an LR2021 chip to download and test. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds firmware support for the RadioLib LR2021 (LR20x0 family) LoRa radio, enabling use on new hardware (e.g., Seeed Tracker-T1000-E-Pro) by introducing a dedicated radio interface and wiring it into radio initialization and type detection.
Changes:
- Add LR20x0/LR2021 RadioInterface adapter (common LR20x0 template + LR2021 concrete interface).
- Integrate LR2021 detection/initialization into
initLoRa()and extendLoRaRadioType. - Pin RadioLib to a specific upstream commit that includes LR2021 support.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mesh/RadioInterface.cpp | Adds LR2021 include and init block to create/configure LR2021 radio interface. |
| src/mesh/LR20x0Interface.h | Declares LR20x0 template adapter used as base for LR2021. |
| src/mesh/LR20x0Interface.cpp | Implements LR20x0 adapter behavior (init, RX/TX control, sleep, CAD, metadata). |
| src/mesh/LR2021Interface.h | Declares LR2021 concrete interface type. |
| src/mesh/LR2021Interface.cpp | Implements LR2021 constructor wiring into LR20x0 base. |
| src/mesh/InterfacesTemplates.cpp | Adds template instantiation for LR20x0Interface. |
| src/detect/LoRaRadioType.h | Adds LR2021_RADIO enum entry for runtime identification. |
| platformio.ini | Updates RadioLib dependency to a commit archive that presumably contains LR2021 support. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support LR20x0
Seeed introduces the Tracker-T1000-E-Pro, featuring support for LR2021.
This represents a split from the original submission #10067, specifically covering the portion that adds support for LR2021.
LoRa Module Update: LR2021
The LoRa subsystem has been updated to support the LR20x0 series modules. Since the Pro version utilizes the LR2021 to replace the LoRa hardware found in the previous iteration, this update introduces the corresponding software adaptations required to ensure the LR2021 module communicates correctly and functions properly on the T1000-E-Pro board.