ci: specify master branch for meshery checkout in e2etests by 2004Pruthvi · Pull Request #195 · meshery-extensions/meshery-cilium

2004Pruthvi · 2026-03-17T08:16:37Z

Description
This PR addresses the issue where the e2etests workflow was checking out the meshery/meshery repository in a "detached HEAD" state. By explicitly specifying ref: master, we ensure that the subsequent steps have the correct branch context to perform a push.
Changes
Updated actions/checkout to v6 for all checkout steps to ensure version consistency and security.
Updated actions/upload-artifact to v8.
Updated actions/download-artifact to v8.
Added ref: master to the meshery/meshery checkout to resolve the detached HEAD failure.
Fixes
Fixes #190

2004Pruthvi · 2026-03-17T08:17:12Z

Hi @leecalcote / @theBeginner86, I've just submitted a PR to fix this. I've updated the e2etests.yaml to explicitly checkout the master branch, which should resolve the detached HEAD failure during doc publishing. Looking forward to your feedback!

leecalcote · 2026-03-19T17:12:38Z

Running build checks...

Copilot

Pull request overview

Updates CI configuration to ensure the E2E workflow checks out the meshery/meshery repo on a named branch (avoiding detached HEAD) and modernizes parts of the repo’s golangci-lint configuration.

Changes:

Pin meshery/meshery checkout in e2etests workflow to ref: master to avoid detached HEAD.
Update .golangci.yml to newer linter configuration schema (depguard rules, mnd rename, gosec excludes, gci sections).
Remove some prior golangci-lint configuration (skip-dirs, service block, comments).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
.golangci.yml	Migrates/adjusts golangci-lint config and removes prior exclusions/version pin block.
.github/workflows/e2etests.yaml	Ensures the external repo checkout targets `master` explicitly.

Comments suppressed due to low confidence (1)

.golangci.yml:1

The config adds linters-settings.mnd and an exclude-rules entry for mnd, but mnd is not enabled (with disable-all: true, it won’t run). If the intent is to actually enforce magic-number checks, add mnd under linters.enable; otherwise, remove the mnd settings/exclude rule to avoid confusing dead configuration.

linters-settings:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

-    - internal/cache
-    - internal/renameio
-    - internal/robustio
  timeout: 5m


+    rules:
+      main:
+        files:
+          - $all
+        deny:
+          - pkg: "github.com/sirupsen/logrus"
+            desc: "logging is allowed only by logutils.Log"


+  mnd:
+    checks:
+      - argument
+      - case
+      - condition
+      - return


Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

lekaf974

if you modify this use latest version please

lekaf974 · 2026-03-20T11:40:24Z

              echo "version=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV
            fi
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v4


Suggested change

- uses: actions/checkout@v4

- uses: actions/checkout@v6

lekaf974 · 2026-03-20T11:40:58Z

+          ref: master
      - name: DownloadJSON
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4


Suggested change

uses: actions/download-artifact@v4

uses: actions/download-artifact@v8

hank you for the catch, @lekaf974! I've updated the workflow to use checkout@v6 and download-artifact@v8 as suggested. Ready for another look.

2004Pruthvi · 2026-03-20T11:59:55Z

Also, could someone please approve the workflows so CI checks can run?

2004Pruthvi · 2026-03-25T18:11:19Z

Hi @lekaf974, I’ve addressed all the requested changes and updated the workflow versions (checkout@v6, download-artifact@v8).

Could you please take another look when you have time? Thanks!

lekaf974 · 2026-03-31T23:08:11Z

@2004Pruthvi can you include golangci-lint changes in another PR please

Signed-off-by: pruthvi@2004 <pruthviraj462004@gmail.com@2004Pruthvi.noreply.github.com>

2004Pruthvi · 2026-04-01T04:57:16Z

Hi @lekaf974, I have finalized the updates to this PR:
Atomicity: Restored the original .golangci.yml. I will move the linter modernization to a separate PR as requested.
Upgraded Actions: Updated the workflow to use the latest GitHub Action versions (checkout@v6, upload-artifact@v8, and download-artifact@v8).
Core Fix: Kept the ref: master addition to resolve the detached HEAD issue (#190).
I believe this is now ready for a final review. Thank you.

Copilot

Pull request overview

This PR fixes a CI issue where the e2etests workflow was checking out the meshery/meshery repository in a detached HEAD state, which prevented subsequent push operations from succeeding. The fix explicitly specifies the ref: master parameter to ensure the checkout operates on a proper branch context.

Changes:

Added ref: master to the meshery/meshery checkout step to ensure a non-detached HEAD state
Upgraded GitHub Actions versions: actions/checkout (v4→v6), actions/upload-artifact (v4→v8), and actions/download-artifact (v2→v8)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

2004Pruthvi · 2026-04-03T06:12:42Z

The linter modernization has been moved to #[Insert-New-PR-Number-Here]. PR #195 is now strictly focused on the CI infrastructure fix and GitHub Action version bumps. Ready for a final look! CC: @lekaf974

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

2004Pruthvi force-pushed the fix/ci-checkout-branch branch 2 times, most recently from a38d680 to e8c8dee Compare March 19, 2026 17:09

leecalcote requested a review from Copilot March 19, 2026 17:12

Copilot AI reviewed Mar 19, 2026

View reviewed changes

Copilot started reviewing on behalf of leecalcote March 19, 2026 17:25 View session

2004Pruthvi requested a review from Copilot March 19, 2026 17:27

Copilot AI reviewed Mar 19, 2026

View reviewed changes

Copilot started reviewing on behalf of 2004Pruthvi March 19, 2026 17:35 View session

lekaf974 requested changes Mar 20, 2026

View reviewed changes

2004Pruthvi requested a review from lekaf974 March 23, 2026 05:04

2004Pruthvi force-pushed the fix/ci-checkout-branch branch from 1a0cb2a to 07009d5 Compare April 1, 2026 04:17

ci: specify master branch for meshery checkout in e2etests

036ee56

Signed-off-by: pruthvi@2004 <pruthviraj462004@gmail.com@2004Pruthvi.noreply.github.com>

2004Pruthvi force-pushed the fix/ci-checkout-branch branch from 07009d5 to 036ee56 Compare April 1, 2026 04:21

2004Pruthvi requested a review from Copilot April 1, 2026 11:26

Copilot started reviewing on behalf of 2004Pruthvi April 1, 2026 11:27 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

Comment thread .github/workflows/e2etests.yaml

Comment thread .github/workflows/e2etests.yaml

chore: upgrade checkout action to v6 (latest) and maintain atomic CI fix

9d73741

2004Pruthvi force-pushed the fix/ci-checkout-branch branch from 4bd4837 to 9d73741 Compare April 1, 2026 11:39

2004Pruthvi requested a review from Copilot April 1, 2026 11:43

Copilot started reviewing on behalf of 2004Pruthvi April 1, 2026 11:43 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

2004Pruthvi mentioned this pull request Apr 3, 2026

chore: migrate to golangci-lint v2 and modernize configuration #196

Open

2004Pruthvi requested a review from Copilot April 9, 2026 10:31

Copilot started reviewing on behalf of 2004Pruthvi April 9, 2026 10:31 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

2004Pruthvi requested a review from Copilot April 10, 2026 03:38

Copilot started reviewing on behalf of 2004Pruthvi April 10, 2026 03:39 View session

saurabhraghuvanshii approved these changes Apr 13, 2026

View reviewed changes

	uses: actions/download-artifact@v4
	uses: actions/download-artifact@v8

Conversation

2004Pruthvi commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

2004Pruthvi commented Mar 17, 2026

Uh oh!

leecalcote commented Mar 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

lekaf974 left a comment

Choose a reason for hiding this comment

Uh oh!

lekaf974 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

lekaf974 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

2004Pruthvi Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

2004Pruthvi commented Mar 20, 2026

Uh oh!

2004Pruthvi commented Mar 25, 2026

Uh oh!

lekaf974 commented Mar 31, 2026

Uh oh!

2004Pruthvi commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

2004Pruthvi commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

2004Pruthvi commented Mar 17, 2026 •

edited

Loading