Skip to content

Fix: Do not embed (dirty) in the docker built version - #131

Merged
junderw merged 1 commit into
mempoolfrom
junderw/fix-dirty-docker-builds
Jan 1, 2026
Merged

junderw merged 1 commit into
mempoolfrom
junderw/fix-dirty-docker-builds

Conversation

@junderw

@junderw junderw commented Jan 1, 2026

Copy link
Copy Markdown
Member

I noticed all the docker builds have (dirty) string in their versions.

It's because Dockerfile's COPY . . doesn't copy Dockerfile because it's ignored by docker by default.

So git sees this as "you deleted Dockerfile but haven't committed it" and the status is dirty.

@knorrium
knorrium self-requested a review January 1, 2026 15:08

@knorrium knorrium left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@junderw

junderw commented Jan 1, 2026

Copy link
Copy Markdown
Member Author

FYI: I found the problem by pushing a tag on my personal repo and adding git status --short before the cargo build step in Dockerfile.

It showed Dockerfile was deleted on the git status.

Then I verified this fixed it by adding some logging to the build file and trying to build locally after deleting Dockerfile manually.

Self tACK

@junderw
junderw merged commit d5dfbb1 into mempool Jan 1, 2026
9 checks passed
@junderw
junderw deleted the junderw/fix-dirty-docker-builds branch January 1, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants