Skip to content

server.features should always be supported #149

Description

@craigraw

Currently server.features is gated behind electrum-discovery. Both Electrum and Sparrow call this RPC, and connection fails when it is not available. It should always be supported as a standard RPC in the Electrum protocol.

Activity

  1. junderw commented on May 24, 2026

    @junderw
    SponsorMember

    #150 will allow for the query to work without the discovery feature, but it will return an empty HashMap for hosts.

    Let me know if you think we should allow people to pass in hosts at startup even without electrum-discovery. (I am not familiar with how the hosts value is used by clients)

  2. craigraw commented on May 24, 2026

    @craigraw
    CollaboratorAuthor

    Thanks for the quick work on this. I don't use hosts in Sparrow, but I think your approach is reasonable - leave hosts empty when the operator does not want to advertise it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions