Skip to content

Don't force panics in the Rust API #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shnatsel wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Don't force panics in the Rust API #1484

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5801e75
Expose fallibility of chroma_location() instead of forcing a panic
Shnatsel Apr 4, 2026
74488ff
Refactor infallible conversions to make it more clear
Shnatsel Apr 4, 2026
be4bee5
Return Option instead of Result, for consistency with bits_per_compon…
Shnatsel Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/rust_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,12 +416,12 @@ impl Picture {

/// Chromaticity coordinates of the source colour primaries.
pub fn color_primaries(&self) -> pixel::ColorPrimaries {
self.inner.seq_hdr.as_ref().unwrap().pri.try_into().unwrap()
self.inner.seq_hdr.as_ref().unwrap().pri.into()
}

/// Transfer characteristics function.
pub fn transfer_characteristic(&self) -> pixel::TransferCharacteristic {
self.inner.seq_hdr.as_ref().unwrap().trc.try_into().unwrap()
self.inner.seq_hdr.as_ref().unwrap().trc.into()
}

/// Matrix coefficients used in deriving luma and chroma signals from the
Expand All @@ -442,8 +442,8 @@ impl Picture {
}

/// Sample position for subsampled chroma.
pub fn chroma_location(&self) -> pixel::ChromaLocation {
self.inner.seq_hdr.as_ref().unwrap().chr.try_into().unwrap()
pub fn chroma_location(&self) -> Option<pixel::ChromaLocation> {
self.inner.seq_hdr.as_ref().unwrap().chr.try_into().ok()
}
}

Expand Down
Loading