Repository navigation
Add support for Zopfli compression. - #363
Merged
Merged
Conversation
Zopfli is a tool for gzip/deflate/zlib compatible compression that runs much slower than the standard implementations, but produces measurably better compression ratios. The resultant compressed files are 100% compatible with standrd gzip tooling for extraction, so this provides a way for users to get better compression ratios without sacrificing portability of the resultant archives.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small and cohesive, with only a minor test portability nit identified.
Pull request overview
This PR adds a new compression option to makeself archives using Zopfli, enabling better gzip-compatible compression ratios while keeping output compatible with standard gzip tooling.
Changes:
- Add
--zopfliCLI flag and wire it into the compressor selection logic inmakeself.sh. - Document the new option in the man page (
makeself.1). - Extend CI and test coverage to exercise the new compression mode.
File summaries
| File | Description |
|---|---|
test/extracttest |
Adds a new extraction/check test path for --zopfli. |
makeself.sh |
Adds --zopfli CLI handling and compressor command mapping. |
makeself.1 |
Documents the new --zopfli option. |
.github/workflows/build.yml |
Installs zopfli in Linux CI images so the new test can run. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
megastep
requested changes
Sep 4, 2026
megastep
left a comment
megastep
left a comment
Owner
There was a problem hiding this comment.
Thanks, I'll merge it if you make the tests more resilient on platforms lacking this package (such as Rocky Linux here).
It’s technically available via EPEL, but it’s also likely fine to just skip that case instead of dealing with pulling in EPEL given that the packaged version is functionally identical across the tested distros.
megastep
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zopfli is a tool for gzip/deflate/zlib compatible compression that runs much slower than the standard implementations, but produces measurably better compression ratios.
The resultant compressed files are 100% compatible with standard gzip tooling for extraction, so this provides a way for users to get better compression ratios without sacrificing portability of the resultant archives.