Skip to content

Update makeself-header.sh to better handle relative paths and provide… #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poliphant wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update makeself-header.sh to better handle relative paths and provide… #328

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fa4d88
Update makeself-header.sh to better handle relative paths and provide…
poliphant Apr 12, 2024
b3a9a75
Update makeself-header.sh
poliphant Apr 15, 2024
efc23d1
Merge branch 'master' into patch-1
megastep Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion makeself-header.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@ SIGNATURE="$Signature"
TMPROOT=\${TMPDIR:=/tmp}
USER_PWD="\$PWD"
export USER_PWD
ARCHIVE_DIR=\`dirname "\$0"\`
ARCHIVE_DIR=\$( cd -- "\$(dirname "\$0")" >/dev/null 2>&1 ; echo \$PWD )

@megastep megastep Apr 13, 2024

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One problem here is that the $() syntax is a modern bash-ism which is not very portable (unlike the backtick approach).

export ARCHIVE_DIR
ARCHIVE_BASE=\`basename "\$0"\`
export ARCHIVE_BASE


label="$LABEL"
script="$SCRIPT"
Expand Down