Skip to content

fix(matching): prefer original audio in combined format #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tcely wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

fix(matching): prefer original audio in combined format #1452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tubesync/sync/matching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,20 @@ def get_best_combined_format(media):
matches.add(fmt['id'])
by_fmt_id[fmt['id']] = fmt
by_language[fmt['language_code']] = fmt['id']
if 'format_note' in fmt and '(default)' in fmt['format_note']:
by_fmt_id['default'] = fmt
if 'format_note' in fmt:
if '(original)' in fmt['format_note']:
by_fmt_id['original'] = fmt
if '(default)' in fmt['format_note']:
by_fmt_id['default'] = fmt

# nothing matched, return early
if not matches:
return False, False

# prefer original
if 'original' in by_fmt_id and 'id' in by_fmt_id['original']:
return True, by_fmt_id['original']['id']

# use any available matching format
return get_fallback_id(by_fmt_id, by_language, exact=True, fallback_id=matches.pop())

Expand Down