Initial work on upgrading all the dependencies - #110
Draft
rahulbot wants to merge 33 commits into
Draft
Conversation
rahulbot
force-pushed
the
evaluate-dependency-upgrade
branch
from
August 24, 2026 13:10
a567ac6 to
2f01fa7
Compare
rahulbot
force-pushed
the
evaluate-dependency-upgrade
branch
from
August 25, 2026 13:00
2f01fa7 to
c92d6b6
Compare
Contributor
Author
|
Full report, after rebasing to verify unit tests and such still work:
|
Yet more unit test fixes
…acloud/metadata-lib into evaluate-dependency-upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've gone through one by one and upgraded each dependency to the latest. After each I ran all the unit tests, and used the new
scripts/evaluate-against-warc.pyto look for differences in metadata results against a recent WARC file with about 700 stories. That script uses a prior warc to compare metadata results when running the updated extraction code against the exact same URL and HTML content.I did Trafilatura last (#105), and it creates errors that look like this:
These indicate that there is a difference of > 20% in the length of the extracted content. Overall, the result is "Done with 138 fails and 569 passes (707 total stories)". The vast majority are failures indicating a noticeable difference in text_content length like this, however only a few are in English so it is hard to debug.⚠️ This will require some manual review to understand if content is being extracted differently in any kind of important way across those 20% of stories ⚠️ .
Besides a potential data quality difference, changes like this might impact performance. It looks like our
scripts/generate_stats.pyis one way to assess this. Here's the run pre and post changes. This doesn't look worrisome to me as a first comparison.