Fix the Qt finder logic in "bootStrap.bash". - #558
Open
frederick-bruckman wants to merge 4 commits into
Open
frederick-bruckman wants to merge 4 commits into
frederick-bruckman wants to merge 4 commits into
Conversation
* Importantly, on Debian bookworm/trixie/forky and Ubuntu jammy, at
least, the qtchooser for Qt4/5 has no logic for Qt6 at all, so
setting QT_SELECT to qt6 simply fails at link-time.
* Make it clear that --with-qt does nothing (because it's the
default).
* It's just as well to use the tools shipped with Qt6 (in the Qt6
case). Respect QTDIR if it's set, otherwise try the Debian/Ubuntu
location, otherwise fail, but helpfully suggest setting QTDIR in
the environment.
Some versions of cmake have a module for finding Qt, but integrating
it looks like a fairly extensive change that's likely to affect every
platform, and for little benefit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some versions of cmake have a module for finding Qt, but integrating it looks like a fairly extensive change that's likely to affect every platform, and for little benefit.