-
Notifications
You must be signed in to change notification settings - Fork 27
Generalized Tecplot ASCII and Binary Readers/Writers #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lamkina
wants to merge
30
commits into
mdolab:main
Choose a base branch
from
lamkina:file_io
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
6c8fc28
Implemented tecplot ascii and binary readers and writers for n-dimens…
16191ce
Fixing black
3718d06
Adding docs for tecplot module
b277258
Bumped the minor version
0f35428
Fixed exception in external io test to catch all errors
b03bcac
Adding zone input validation, better use of enums, refactoring, and b…
9ebce66
Fixing regex for zone name matching
0288bee
Added terminating comma to regex pattern for zone header
d8fdc99
Fixed regex for zone name matching
660609b
Updating tecplot writers in the weight problem
f88c903
Fixing if checks for types
47903db
Updating tecplot writers in the aero solver
75f59ea
Fixing strand ID and solution time bugs in ASCII writer
80196c6
Fixed random data in ordered zones and added stress testing
63169ee
Added block format writer and reader to adhere to line width constraints
a503e8c
Added line length test for ASCII files
fc5c1c2
Improved the ascii data reader to use multiple separators and ignore …
066a6bd
Added full reader and writer separator support with tests
449c9b9
Cleaning up documentation, imports, and api
c2baf7c
Added tri connectivity property for FE zones with tests
fc5fbe8
Flake 8 is always watching
1e44f71
Added unique indices and nodes to fe zones
b9b83aa
New connectivity handling for FE zones with unique data and connectiv…
b30741e
Fixed remap connectivity bug
99e04c7
Switched remap connectivity to numpy for sppeeeed
7fc9a08
Updgraded the zone name matching to be more robust
512543f
Fixing ordered zones i,j,k ordering bug
61044d1
Merge branch 'main' into file_io
gawng 036c57d
Fixing small bug with header regex
3399dda
Merge branch 'file_io' of github.com:lamkina/baseclasses into file_io
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future people's sake, can you add a comment here explaining what this regex matches?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I need to review and add more tests for the regex patterns. To my knowledge, there's no established rules published by Tecplot that describe the formatting of the ASCII header data. I'm considering simpler approach that removes the regex and just assumes all data follows an
=sign and terminates with either acommaornewlineunless it's surrounded by single or double quotes.