make rasdaemon more modular and add support to use other databases

.github/workflows/auto-remove-waiting-label.yml

@@ -1,7 +1,7 @@
 name: Auto-remove "waiting new revision" label on PR update
 
 on:
-  pull_request:
+  pull_request_target:
     types: [synchronize]
 
 permissions:
@@ -14,4 +14,5 @@ jobs:
       - name: Remove label on PR update
         uses: actions-ecosystem/action-remove-labels@v1
         with:
-          labels: 'waiting new revision'
+          labels: waiting new revision
+          fail_on_error: true

.github/workflows/checkpatch_ignore.txt

@@ -1,7 +1,7 @@
 # .github/workflows/checkpatch_ignore.txt
 
-# Ignore a CONSTANT_COMPARISON that only appears in ras-page-isolation.h
-^ras-page-isolation\.h:.*CONSTANT_COMPARISON
+# Ignore a CONSTANT_COMPARISON that only appears in modules/ras-page-isolation.h
+^modules/ras-page-isolation\.h:.*CONSTANT_COMPARISON
 
-# Ignore a MACRO_ARG_PRECEDENCE that only appears in types.h
-^types\.h:.*MACRO_ARG_PRECEDENCE
+# Ignore a MACRO_ARG_PRECEDENCE that only appears in core/types.h
+^core/types\.h:.*MACRO_ARG_PRECEDENCE

.github/workflows/ci.yml

@@ -14,42 +14,44 @@ jobs:
     strategy:
       matrix:
         arch: [x64_64, aarch64, ppc64le]
-        config: [--disable-all, --enable-all]
+        config: [disable-all=false, disable-all=true]
     steps:
-      - uses: actions/checkout@v2
-      - name: prepare
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y build-essential libsqlite3-dev sqlite3 libtraceevent-dev libtraceevent1 libpci-dev
-      - name: build
-        run: |
-          autoreconf -vfi
-          ./configure ${{ matrix.config }}
-          make
-          sudo make install
+    - uses: actions/checkout@v7
+
+    - name: prepare
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y build-essential meson ninja-build pkg-config \
+                                git cmake libsqlite3-dev sqlite3 \
+                                libtraceevent-dev libtraceevent1 libpci-dev
+    - name: build
+      run: |
+        meson setup build --reconfigure -D${{ matrix.config }}
+        make
+        sudo make install
 
   Fedora:
     name: Fedora
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        arch: [x64_64]
     container:
       image: fedora:rawhide
       options: --privileged
     steps:
-      - uses: actions/checkout@v2
-      - name: prepare
-        run: |
-          dnf install -y mock rpm-build rpmdevtools \
-                         autoconf automake make gcc libtraceevent-devel
-          ln -sf fedora-rawhide-x86_64.cfg /etc/mock/default.cfg
-          rpmdev-setuptree
-      - name: build
-        run: |
-          autoreconf -vfi
-          ./configure
-          make mock
+    - name: prepare
+      run: |
+        dnf install -y git mock rpmdevtools meson gcc make \
+                       libtraceevent-devel
+
+        ln -sf fedora-rawhide-x86_64.cfg /etc/mock/default.cfg
+        rpmdev-setuptree
+
+    - uses: actions/checkout@v7
+
+    - name: build
+      run: |
+        meson setup build -Ddisable-all=true
+        git config --global safe.directory "*"
+        make mock
 
   openEuler:
     name: OpenEuler LTS
@@ -61,30 +63,32 @@ jobs:
       image: openeuler/openeuler:24.03-lts-sp3
       options: --privileged
     steps:
-      - uses: actions/checkout@v2
-      - name: prepare
-        run: |
-          dnf install -y sudo autoconf automake libtool gettext-devel hwdata \
-                         make gcc libtraceevent-devel sqlite-devel sqlite \
-                         pciutils pciutils-devel
-      - name: build
-        run: |
-          autoreconf -vfi
-          ./configure --enable-all
-          make
-          make install
+    - name: prepare
+      run: |
+        dnf install -y sudo meson ninja-build gettext-devel hwdata \
+                       make gcc libtraceevent-devel sqlite-devel sqlite \
+                       pciutils pciutils-devel findutils
+
+    - uses: actions/checkout@v7
+
+    - name: build
+      run: |
+        meson setup build --reconfigure -Ddisable-all=false
+        make
+        make install
 
   Check:
     name: Source code check
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: checkpatch
-        run: |
-            ignore_regex=$(grep -Ev '^\s*#' .github/workflows/checkpatch_ignore.txt | tr '\n' '|')
-            ignore_regex=${ignore_regex%|}
+    - uses: actions/checkout@v7
+
+    - name: checkpatch
+      run: |
+        ignore_regex=$(grep -Ev '^\s*#' .github/workflows/checkpatch_ignore.txt | tr '\n' '|')
+        ignore_regex=${ignore_regex%|}
 
-            output=$(./scripts/checkpatch.pl --terse --show-types --no-summary \
-                     -f $(git ls-files | grep -E '\.[ch]$') | \
-                     grep -Ev "$ignore_regex" || true); echo $output; \
-            if [ -z "$output" ]; then exit 0; fi; exit 1
+        output=$(./scripts/checkpatch.pl --terse --show-types --no-summary \
+                 -f $(git ls-files | grep -E '\.[ch]$') | \
+                 grep -Ev "$ignore_regex" || true); echo $output; \
+        if [ -z "$output" ]; then exit 0; fi; exit 1

.github/workflows/on_tag.yml

@@ -7,7 +7,7 @@ on:
   push:
     # Sequence of patterns matched against refs/tags
     tags:
-      - 'v[0-9]+*'
+    - v[0-9]+*
 
 jobs:
   release:
@@ -16,37 +16,36 @@ jobs:
     outputs:
       upload_url: ${{ steps.create_release.outputs.upload_url }}
     steps:
-      - uses: actions/checkout@v2
-      - name: Release changelog
-        run: |
-          .github/workflows/gen_release.pl body_file.tmp > version
-          echo "version=$(cat version)" >> $GITHUB_ENV
-      - name: Create Release
-        id: create_release
-        uses: actions/create-release@latest
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          tag_name: ${{ github.ref }}
-          release_name: Release ${{ github.ref }}
-          body_path: body_file.tmp
-          draft: false
-          prerelease: true
-      - name: prepare
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y build-essential sqlite3 libtraceevent-dev libtraceevent1
-      - name: Create Source Package for version ${{ env.version }}
-        run: |
-          autoreconf -vfi
-          ./configure --enable-all
-          make dist-bzip2
-      - name: upload
-        env:
-            GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        uses: mchehab/upload-release-asset@v1.0.3
-        with:
-          upload_url: ${{ github.event.release.upload_url }}
-          asset_path: rasdaemon-${{ env.version }}.tar.bz2
-          asset_name: rasdaemon-${{ env.version }}.tar.bz2
-          asset_content_type: application/bzip2
+    - uses: actions/checkout@v2
+    - name: Release changelog
+      run: |
+        .github/workflows/gen_release.pl body_file.tmp > version
+        echo "version=$(cat version)" >> $GITHUB_ENV
+    - name: Create Release
+      id: create_release
+      uses: actions/create-release@latest
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      with:
+        tag_name: ${{ github.ref }}
+        release_name: Release ${{ github.ref }}
+        body_path: body_file.tmp
+        draft: false
+        prerelease: true
+    - name: prepare
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y build-essential meson ninja-build sqlite3 libtraceevent-dev libtraceevent1
+    - name: Create Source Package for version ${{ env.version }}
+      run: |
+        meson setup build --reconfigure -Ddisable-all=false
+        make dist-bzip2
+    - name: upload
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      uses: mchehab/upload-release-asset@v1.0.3
+      with:
+        upload_url: ${{ github.event.release.upload_url }}
+        asset_path: rasdaemon-${{ env.version }}.tar.bz2
+        asset_name: rasdaemon-${{ env.version }}.tar.bz2
+        asset_content_type: application/bzip2

.github/workflows/unittest.yml

@@ -0,0 +1,157 @@
+# SPDX-License-Identifier: GPL-2.0
+
+name: Tests
+
+on:
+  workflow_dispatch:
+  push:
+  pull_request:
+
+jobs:
+  Unittest:
+    name: Default Unit Tests
+    runs-on: ubuntu-latest
+    steps:
+      - name: Start MySQL
+        run: |
+          sudo systemctl start mysql.service
+          mysqladmin ping --host=127.0.0.1 --user=root --password=root
+
+      - name: Install PostgreSQL
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y postgresql postgresql-client
+
+          sudo systemctl start postgresql
+
+          for attempt in {1..30}; do
+            if pg_isready --host=127.0.0.1 --port=5432; then
+              exit 0
+            fi
+            sleep 1
+          done
+
+          sudo systemctl status postgresql --no-pager
+
+      - name: Setup PostgreSQL trust
+        run: |
+          HBA_FILE="$(sudo -u postgres psql --tuples-only --no-align \
+              --command='SHOW hba_file')"
+          sudo sed -i '1i local all rasdaemon trust' "$HBA_FILE"
+
+          echo "Postgres config file $HBA_FILE:"
+          sudo cat "$HBA_FILE"
+          sudo systemctl restart postgresql
+
+          for attempt in {1..30}; do
+            if pg_isready --host=127.0.0.1 --port=5432; then
+              exit 0
+            fi
+            sleep 1
+          done
+
+          sudo systemctl status postgresql --no-pager
+          exit 1
+
+      - name: Create MySQL database
+        env:
+          MYSQL_PWD: root
+        run: |
+          mysql --host=127.0.0.1 --user=root << EOF
+            CREATE USER 'rasdaemon'@'%' IDENTIFIED BY 'mypass';
+            CREATE DATABASE  rasdaemon_test;
+            GRANT ALL PRIVILEGES ON rasdaemon_test.* TO 'rasdaemon'@'%';
+            FLUSH PRIVILEGES;
+          EOF
+      - name: Create PostgreSQL database
+        run: |
+          sudo -u postgres psql --set ON_ERROR_STOP=1 << EOF
+            CREATE USER rasdaemon WITH PASSWORD 'mypass';
+            CREATE DATABASE rasdaemon_test OWNER rasdaemon;
+          EOF
+
+          PGPASSWORD='mypass' \
+            psql -h /var/run/postgresql -U rasdaemon \
+                 -d rasdaemon_test --set ON_ERROR_STOP=1 << EOF2
+            CREATE SCHEMA rasdaemon AUTHORIZATION rasdaemon;
+          EOF2
+      - name: Install packages needed by Rasdaemon
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y build-essential meson ninja-build pkg-config \
+                                  git cmake libsqlite3-dev sqlite3 \
+                                  python3-sqlalchemy python3-mysqldb \
+                                  python3-psycopg2 \
+                                  libcmocka-dev libmysqlclient-dev libpq-dev \
+                                  libtraceevent-dev libtraceevent1 libpci-dev
+      - uses: actions/checkout@v7
+      - name: Build rasdaemon
+        run: |
+          meson setup build
+          make
+      - name: Run unittest
+        env:
+          RAS_MYSQL_HOST: ''
+          RAS_MYSQL_PORT: '3306'
+          RAS_MYSQL_USER: rasdaemon
+          RAS_MYSQL_PASSWORD: mypass
+          RAS_MYSQL_DATABASE: rasdaemon_test
+          RAS_PG_HOST: ''
+          RAS_PG_PORT: 5432
+          RAS_PG_USER: rasdaemon
+          RAS_PG_PASSWORD: mypass
+          RAS_PG_SCHEMA: rasdaemon
+          RAS_PG_DATABASE: rasdaemon_test
+        run: |
+          build/unittest -o tap
+      - name: Run Python unittests
+        run: |
+          python3 tests/run.py
+
+  MariaDBUnittest:
+    name: MariaDB Unit Test
+    runs-on: ubuntu-latest
+    steps:
+      - name: Start MariaDB
+        run: |
+          sudo apt-get remove -y mysql-server mysql-client
+          sudo apt-get install -y mariadb-server mariadb-client
+          sudo systemctl start mariadb.service
+
+          sudo mysqladmin ping
+
+      - name: Create MariaDB database
+        env:
+          MYSQL_PWD: root
+        run: |
+          sudo mysql << EOF
+            CREATE USER 'rasdaemon'@'%' IDENTIFIED BY 'mypass';
+            CREATE DATABASE  rasdaemon_test;
+            GRANT ALL PRIVILEGES ON rasdaemon_test.* TO 'rasdaemon'@'%';
+            FLUSH PRIVILEGES;
+          EOF
+      - name: Install packages needed by Rasdaemon
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y build-essential meson ninja-build pkg-config \
+                                  git cmake libsqlite3-dev sqlite3 \
+                                  python3-sqlalchemy python3-mysqldb \
+                                  libcmocka-dev libmariadb-dev-compat \
+                                  libtraceevent-dev libtraceevent1 libpci-dev
+      - uses: actions/checkout@v7
+      - name: Build rasdaemon
+        run: |
+          meson setup build
+          make
+      - name: Run unittest
+        env:
+          RAS_MYSQL_HOST: ''
+          RAS_MYSQL_PORT: '3306'
+          RAS_MYSQL_USER: rasdaemon
+          RAS_MYSQL_PASSWORD: mypass
+          RAS_MYSQL_DATABASE: rasdaemon_test
+        run: |-
+          build/unittest -o tap -g mysql
+      - name: Run Python unittests
+        run: |-
+          python3 -m unittest -v tests.test_ras_db.MysqlRasDatabaseTest