Repository navigation
docs(list): drop the stale-branch and dirty-tree skips from JSON help - #4359
Merged
Merged
Conversation
`wt list --help` described three things the collector no longer does or never did: - `·` and JSON `null` blamed a branch "too stale for the expensive checks". The stale-branch skip was removed in #2098; nothing in `collect/` skips tasks by branch age now. - `default_branch.integration` was "null when a dirty tree skipped the checks". The probes run on the committed HEAD whatever the tree's state (json_v2.rs says so, and `test_integration_positive_match_ignores_cleanliness` pins a dirty `trees_match`); null comes from a timed-out or skipped probe. - "every reason renders as the same `⊂`" is false for `same_commit`, which the table shows as `_` or `–`. Also update the matching `JsonDefaultBranch::integration` docstring (which feeds the published list-v2 schema) and the internal comments in collect/execution.rs that still listed the stale-branch skip.
worktrunk-bot
commented
Oct 3, 2026
worktrunk-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
The status_symbols.rs module doc still has a Gate 3 exception that reads "Exception — stale branches and --skip-tasks:". This PR removes that same stale-branch claim from collect/execution.rs, but this copy sits outside the diff. --skip-tasks doesn't exist as a flag anymore either (no other match under src/). I'm pushing a commit that rewords the exception to cover tasks the column plan skips, which is what still seeds conservative defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wt list --help(and the generatedlist.mdpages, skill mirrors, andlist-v2.jsonschema) explains·, JSONnull, anddefault_branch.integrationin ways the collector no longer matches. This corrects three claims. No behavior changes.·andnull. Cache remaining expensive tasks, unify wt list and picker #2098 removed the stale-branch skip (stale_branches), and nothing insrc/commands/list/collect/skips tasks by branch age now. The remaining sources ofnullare a timeout, a skipped probe (column plan or unborn branch), or a failed forge fetch.integration"null when a dirty tree skipped the checks". Dirty trees don't skip the probes. They run on the committed HEAD either way, asjson_default_branchsays andtest_integration_positive_match_ignores_cleanlinesspins with a dirtytrees_matchresult. A dirty integrated branch reports its reason, notnull.⊂"."same_commit"renders as_(or–with uncommitted changes), perIntegrationReason::SameCommitand the Default-branch symbol table in the same help page.⊂also needs a clean tree.The same commit updates the
JsonDefaultBranch::integrationdocstring, which generates the published schema description, and four internal comments incollect/execution.rsthat still listed the stale-branch skip.No test is added because this changes only prose. Help snapshots and doc mirrors are regenerated, and
test_docs_are_in_syncpasses.