Skip to content

fix(config): skip a rejected env override in every command, not just wt list #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
worktrunk-bot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(config): skip a rejected env override in every command, not just wt list #4358

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f26039a
docs(config): say which commands stop on an invalid env override
worktrunk-bot Oct 3, 2026
7d1399d
fix(config): skip a rejected env override in every command
worktrunk-bot Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/content/docs/config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ On first run without shell integration, Worktrunk offers to install it. On first
## Environment variables

All user config options can be overridden with environment variables using the `WORKTRUNK_` prefix.
Invalid environment overrides are ignored with a warning; other valid overrides still apply.
An invalid override is reported with a warning. `wt list` skips it and still applies the other valid overrides; commands such as `wt switch`, `wt merge`, and `wt remove` stop with an error instead.

### Naming convention

Expand Down
2 changes: 1 addition & 1 deletion plugins/worktrunk/skills/worktrunk/reference/config.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion skills/worktrunk/reference/config.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/cli/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2595,7 +2595,7 @@ On first run without shell integration, Worktrunk offers to install it. On first
## Environment variables

All user config options can be overridden with environment variables using the `WORKTRUNK_` prefix.
Invalid environment overrides are ignored with a warning; other valid overrides still apply.
An invalid override is reported with a warning. `wt list` skips it and still applies the other valid overrides; commands such as `wt switch`, `wt merge`, and `wt remove` stop with an error instead.

### Naming convention

Expand Down
6 changes: 3 additions & 3 deletions src/config/user/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ pub use sections::{
pub enum LoadError {
/// A file parser failed, retaining its source and raw diagnosis.
File(super::ConfigParseError),
/// Config files parsed cleanly; applying env-var overrides failed.
/// `vars` lists the exact `WORKTRUNK_*` env vars that were parsed
/// as `(name, value)` pairs.
/// An env-var override setting was rejected; other settings' overrides
/// may still apply. `vars` lists the `WORKTRUNK_*` env vars forming the
/// rejected setting as `(name, value)` pairs.
Env {
err: String,
vars: Vec<(String, String)>,
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/integration__integration_tests__help__help_config_long.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ On first run without shell integration, Worktrunk offers to install it. On first
Environment variables

All user config options can be overridden with environment variables using the WORKTRUNK_ prefix.
Invalid environment overrides are ignored with a warning; other valid overrides still apply.
An invalid override is reported with a warning. wt list skips it and still applies the other valid overrides; commands such as wt switch, wt merge, and wt remove stop with an error instead.

Naming convention

Expand Down
Loading