Conversation
Add a dedicated page covering how admins should upgrade their PostgreSQL server, including bare-metal (pg_upgrade and pg_dump/pg_restore) and Docker-based approaches. Move the ANALYZE VERBOSE post-upgrade note from preparations.rst into the new page and replace it with a cross-reference. Register the new page in the upgrade section toctree. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Newest code from mattermost has been published to preview environment for Git SHA 041050b |
Add a notice that the Docker upgrade steps target the official Mattermost Docker deployment at https://github.com/mattermost/docker. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Update the Docker upgrade guide to use the .env variable POSTGRES_IMAGE_TAG rather than editing docker-compose.yml directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Newest code from mattermost has been published to preview environment for Git SHA d470a77 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a new "Upgrading PostgreSQL" administration guide page and links to it from the Upgrade Mattermost guide; updates deployment preparations to replace an Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
source/administration-guide/upgrade/upgrading-postgres.rst (1)
14-19: Add quick success checks after key operationsFor Novice Nate, the procedure is clear but lacks explicit verification points after stop/restore/start actions. Add short “Expected result” checks (service status, DB version, restore completion) to reduce uncertainty.
As per coding guidelines, "Include expected output or success checks after key steps to help readers verify progress."
Also applies to: 34-83, 93-133
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/administration-guide/upgrade/upgrading-postgres.rst` around lines 14 - 19, Add explicit "Expected result" verification lines after each key step (specifically after "Back up your database", "Check supported versions", and "Stop Mattermost" and similar steps in ranges 34-83 and 93-133) that state what to check (e.g., backup completed message or file exists, PostgreSQL target version reported by psql --version or SELECT version(), Mattermost service is inactive via systemctl status or ps output, and restore completion confirmation), and place them immediately below the corresponding step text so Novice Nate can verify success before proceeding.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@source/administration-guide/upgrade/upgrading-postgres.rst`:
- Around line 111-122: Replace the incorrect container restart instruction
"docker start db" with a command that recreates the container from the updated
compose file so the new image tag is applied; update the step that currently
references docker start (text mentioning "Start the new PostgreSQL container"
and the command "docker start db") to instruct using docker compose up -d
--force-recreate db (or equivalent compose up command) so the container is
recreated with the new PostgreSQL image and the updated docker-compose.yml is
applied.
In `@source/deployment-guide/server/preparations.rst`:
- Around line 122-124: The advisory uses a low-severity admonition (".. note::")
for a major PostgreSQL upgrade redirect; change the directive to a
higher-severity admonition by replacing the ".. note::" token with "..
important::" in the same block so the guidance about upgrading a major version
of PostgreSQL is surfaced as high-impact information.
---
Nitpick comments:
In `@source/administration-guide/upgrade/upgrading-postgres.rst`:
- Around line 14-19: Add explicit "Expected result" verification lines after
each key step (specifically after "Back up your database", "Check supported
versions", and "Stop Mattermost" and similar steps in ranges 34-83 and 93-133)
that state what to check (e.g., backup completed message or file exists,
PostgreSQL target version reported by psql --version or SELECT version(),
Mattermost service is inactive via systemctl status or ps output, and restore
completion confirmation), and place them immediately below the corresponding
step text so Novice Nate can verify success before proceeding.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f54fc339-da90-4bae-b80c-efd37ca78e33
📒 Files selected for processing (3)
source/administration-guide/upgrade-mattermost.rstsource/administration-guide/upgrade/upgrading-postgres.rstsource/deployment-guide/server/preparations.rst
|
Newest code from mattermost has been published to preview environment for Git SHA 3d56d01 |
- Replace "docker start postgres" with "docker compose up -d --force-recreate postgres" so the container is recreated with the updated image tag from .env - Promote the PostgreSQL upgrade cross-reference in preparations.rst from ".. note::" to ".. important::" to reflect its high-impact nature Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Newest code from mattermost has been published to preview environment for Git SHA fe82d1a |
agarciamontoro
left a comment
There was a problem hiding this comment.
Looks good! Succinct and to the point, thank you!
|
Newest code from mattermost has been published to preview environment for Git SHA 2bbb2e8 |
|
Newest code from mattermost has been published to preview environment for Git SHA 0dfba3c |
Summary
We had frequent questions from customer on how to update their Postgres cluster. This document aims to cover that gap. It cover both https://github.com/mattermost/docker and a standalone postgres server. Cluster upgrade are not covered as they are too complex for ours docs. These setups get managed by specialized DBAs.
AI Summary
upgrading-postgres.rstunder the upgrade section covering how admins should upgrade their PostgreSQL serverpg_upgradeandpg_dump/pg_restore, and Docker-based upgradesANALYZE VERBOSEpost-upgrade note frompreparations.rstinto the new page and replaces it with a cross-referenceTest plan
preparations.rstresolves to the new pageANALYZE VERBOSEcallout no longer appears on the preparations pagemake linkcheckto confirm no broken links🤖 Generated with Claude Code