Support more content types for the NSFWProtector#594
Open
Support more content types for the NSFWProtector#594
Conversation
Half-Shot
changed the title
H-Shay
reviewed
Apr 1, 2025
|
|
||
| /** | ||
| * Extract the first frame from a video or image source. | ||
| * @param ffmpegPath The path to the `ffmpeg` binary. |
Contributor
There was a problem hiding this comment.
Should it pull from somewhere in the first third-middle? Just wondering if always pulling from first frame will be easily evaded.
H-Shay
reviewed
Apr 1, 2025
| LogService.warn("NsfwProtection", `No content type header specified`); | ||
| return null; | ||
| } | ||
| console.log(contentType); |
Contributor
There was a problem hiding this comment.
Wondering if this is a stray from debugging :)
H-Shay
reviewed
Apr 1, 2025
Contributor
H-Shay
left a comment
H-Shay
left a comment
There was a problem hiding this comment.
This is awesome, just had one question. Otherwise I would love to see a test or two of new functionality but am not going to gate approval behind that :)
Contributor
|
@Half-Shot just curious about the status on this? I think we can probably merge it but I've lost context and want to make sure there's nothing I am forgetting. |
Contributor
Author
|
Hey @H-Shay, I'm mostly happy with this but I want to do more testing before we merge. I can take a look this afternoon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to work around the limitations of tensorflow's models, this PR transcodes anything that might look like an image or video into something we can then pass through the model.
Tested and working.
The list of improvements are: