chore(sdk): reload_from_storage emits an EventsOrigin::Cache#6451
Open
Hywan wants to merge 1 commit intomatrix-org:mainfrom
Open
chore(sdk): reload_from_storage emits an EventsOrigin::Cache#6451Hywan wants to merge 1 commit intomatrix-org:mainfrom
reload_from_storage emits an EventsOrigin::Cache#6451Hywan wants to merge 1 commit intomatrix-org:mainfrom
Conversation
This patch updates `PinnedEventCacheStateLockWriteGuard::reload_from_storage`. It calls `notify_subscribers` with `EventsOrigin::Sync`. This patch changes for `EventsOrigin::Cache`. All events are indeed loaded from the store, so the cache.
poljar
approved these changes
Apr 15, 2026
Contributor
poljar
left a comment
There was a problem hiding this comment.
All events are indeed loaded from the store, so the cache.
So the cache!?!? The cache what? 😅
Is this fixing a bug? Do we want a regression tests for such a bug?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6451 +/- ##
==========================================
- Coverage 89.84% 89.82% -0.03%
==========================================
Files 378 378
Lines 104337 104337
Branches 104337 104337
==========================================
- Hits 93746 93723 -23
- Misses 7000 7017 +17
- Partials 3591 3597 +6 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates
PinnedEventCacheStateLockWriteGuard::reload_from_storage. It callsnotify_subscriberswithEventsOrigin::Sync. This patch changes forEventsOrigin::Cache. All events are indeed loaded from the store, so the cache.CHANGELOG.mdfiles.